-
Bug
-
Resolution: Fixed
-
Minor
-
3.11.5, 4.0
-
MOODLE_311_STABLE, MOODLE_400_STABLE
-
MOODLE_311_STABLE
-
Before Moodle 2.3 we used SimpleTest instead of PHPUnit test.
It had its own way to specify code coverage and was about to add some static members to the unit test case classes:
public static $includecoverage = array('lib/dml');
|
public static $excludecoverage = array('lib/dml/somedir');
|
When we moved to PHPUnit, that uses its own code coverage annotations and include/exclude coverage definitions, a few of those old members were not removed from core.
This issue is about:
- Remove remaining ones from core.
- If needed (not yet being applied) find their PHPUnit alternatives.
This is the current list of remaining cases:
$ ag 'includecoverage|excludecoverage'
|
question/type/numerical/tests/questiontype_test.php
|
42: public static $includecoverage = array(
|
|
question/type/tests/questiontype_test.php
|
40: public static $includecoverage = array('question/type/questiontypebase.php');
|
|
question/type/shortanswer/tests/questiontype_test.php
|
41: public static $includecoverage = array(
|
|
question/type/calculated/tests/questiontype_test.php
|
40: public static $includecoverage = array(
|
|
question/type/calculatedsimple/tests/questiontype_test.php
|
42: public static $includecoverage = array(
|
|
lib/tests/moodlelib_test.php
|
31: public static $includecoverage = array('lib/moodlelib.php');
|
|
mod/quiz/accessrule/securewindow/tests/rule_test.php
|
40: public static $includecoverage = array('mod/quiz/accessrule/securewindow/rule.php');
|
Ciao