Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73574

WS mod_assign_get_grades is not returning all group submission grades

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.9.11, 3.10.8, 3.11.4
    • Assignment
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE

      When a teacher reviews grading table, grading status differ from web and app.

      The problem is that the WS is not returning grades on group submissions when there are no submission for the user.

       

      On gradingtable.php the SQL that defines the table information says:

       // For group assignments, there can be a grade with no submission.
      		 
              $from .= ' LEFT JOIN {assign_grades} g
      		 
                                  ON g.assignment = :assignmentid2
      		 
                                 AND u.id = g.userid
      		 
                                 AND (g.attemptnumber = s.attemptnumber OR s.attemptnumber IS NULL) ';

      While on the WS is only checking:

      [...] AND s.attemptnumber = ag.attemptnumber

      I think we should add the "OR s.attemptnumber IS NULL" to the SQL.

            jleyva Juan Leyva
            pferre22 Pau Ferrer
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.