Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-73568

Show accepted file types for stored file config settings

XMLWordPrintable

    • MOODLE_400_STABLE
    • MOODLE_401_STABLE
    • Hide
      1. Log in as admin
      2. Navigate to Appearance > Logos in site administration
      3. Confirm Logo and Compact logo config settings state the following: 

        Accepted file types:
        		 
         
        		 
            Image (JPEG) .jpg
        		 
            Image (PNG) .png

      4. Try to upload a non-image file (e.g. .txt) to the Logo field
      5. Confirm you see an error starting file type was not accepted
      6. Upload a .jpg image to the Logo field
      7. Press Save changes
      8. Confirm same uploaded image is present in Logo field when page reloads
      9. Log out
      10. Confirm uploaded image is shown on login page
      11. Log in as admin
      12. Navigate to Appearance > Themes > Boost in site administration
      13. Confirm the Additional theme preset files config setting states the following: 

        Accepted file types:
        		 
         
        		 
            text/x-scss .scss

      Show
      Log in as admin Navigate to Appearance > Logos in site administration Confirm Logo and Compact logo config settings state the following: Accepted file types:   Image (JPEG) .jpg Image (PNG) .png Try to upload a non-image file (e.g. .txt ) to the Logo field Confirm you see an error starting file type was not accepted Upload a .jpg image to the Logo field Press Save changes Confirm same uploaded image is present in Logo field when page reloads Log out Confirm uploaded image is shown on login page Log in as admin Navigate to Appearance > Themes > Boost in site administration Confirm the Additional theme preset files config setting states the following: Accepted file types:   text/x-scss .scss

      For admin config settings of type admin_setting_configstoredfile, it's not easy for a user to determine what the accepted list of file types is other than via trial and error, e.g.

      Most uses of this config type already define the 'accepted_types' property, and the renderer code for displaying said information already exists (it's displayed on most other file manager elements) so we should use it

      We can remove a TODO left over for MDL-32020 too

        1. Screenshot_2022-01-12 Moodle Master Administration Appearance Themes Boost.png
          32 kB
          Paul Holden
        2. MDL-73568 accepted.png
          77 kB
          Simey Lameze
        3. 3_MDL-73568_master.png
          85 kB
          John Edward Pedregosa
        4. 8_MDL-73568_master.png
          77 kB
          John Edward Pedregosa
        5. 13_MDL-73568_master.png
          82 kB
          John Edward Pedregosa
        6. 5_MDL-73568_master.png
          72 kB
          John Edward Pedregosa
        7. 10_MDL-73568_master.png
          154 kB
          John Edward Pedregosa

            pholden Paul Holden
            pholden Paul Holden
            Simey Lameze Simey Lameze
            Victor Déniz Falcón Victor Déniz Falcón
            John Edward Pedregosa John Edward Pedregosa
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 40 minutes
                4h 40m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.