Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72979

Remove any reference in core to plain git protocol uses (against github)

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • 4.1
    • 3.9.10, 3.10.7, 3.11.3
    • General
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE
    • MOODLE_401_STABLE
    • Easy
    • Hide

      Sanity check

      1. In the base directory of the moodle checkout (integration.git master branch) run:

        grep -Pr 'git:\/\/' --exclude composer.phar
        

      2. Verify that there isn't any file (php, txt...) using the git:// protocol.
      3. That's all!
      Show
      Sanity check In the base directory of the moodle checkout (integration.git master branch) run: grep -Pr 'git:\/\/' --exclude composer.phar Verify that there isn't any file (php, txt...) using the git:// protocol. That's all!

      Soon, GitHub will completely stop the git (unencrypted/unauthenticated) anonymous protocol to work:

      https://github.blog/2021-09-01-improving-git-protocol-security-github/#no-more-unauthenticated-git

      This issue is about to look for all the uses in core (of "git://github.com/") and replace them by future-working "https://github.com/".

      Really there aren't many (it seems https is already the 99% commonly used one):

      $ ag 'git:\/\/github\.com\/'
      repository/s3/README_MOODLE.txt
      5:Cloned from git://github.com/tpyo/amazon-s3-php-class.git
       
      h5p/h5plib/v124/joubel/editor/ckeditor/skins/bootstrapck/sample/bootstrapck-sample.html
      80:          by running: <pre>$ git clone git://github.com/Kunstmaan/BootstrapCK4-Skin</pre></p>
      

        1. MDL-72979.png
          16 kB
          John Edward Pedregosa
        2. result.png
          295 kB
          Huong Nguyen

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Huong Nguyen Huong Nguyen
            John Edward Pedregosa John Edward Pedregosa
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 35 minutes
                1h 35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.