Loading...

XML

Word

Printable

Type: Bug
Resolution: Unresolved
Priority: Minor
Fix Version/s: None
Affects Version/s: 3.9.11, 4.0
Component/s: Feedback
Labels:
- ci
- triaged

Affected Branches:
MOODLE_39_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.5 Branch:
MDL-72956-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-72956-405
Pull 5.0 Branch:
MDL-72956-500
Pull 5.0 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_500_STABLE...paulholden:MDL-72956-500
Pull Main Branch:
MDL-72956
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-72956
Testing Instructions:
Hide

Setup

Log in as admin

Create user

Create course

Enrol user as student on course

Navigate to course

Add a Feedback activity

Edit feedback questions, add following:

Q1. Short text answer

Page break

Q2. Short text answer

Navigate back to course

Add another Feedback activity

Edit second feedback questions, add following:

Q3. Short answer text

Page break

Q4. Short answer text

Test

Open two browser tabs

In the first tab open Feedback activity 1 and press Answer the questions

In the second tab open Feedback activity 2 and press Answer the questions

In the first tab, answer Q1 and press Next page

In the second tab, answer Q3 and press Next page

In the first tab, answer Q2 and press Submit your answers

In the second tab, answer Q4 and press Submit your answers

Confirm you were able to submit both sets of answers

Log out

Log in as admin

Navigate to Feedback activity 1

Press Responses

Press Response number: 1

Confirm you see the previously entered response for Q1 & Q2

Navigate to Feedback activity 2

Press Responses

Press Response number: 1

Confirm you see the previously entered response for Q3 & Q4
Show
Setup Log in as admin Create user Create course Enrol user as student on course Navigate to course Add a Feedback activity Edit feedback questions, add following: Q1. Short text answer Page break Q2. Short text answer Navigate back to course Add another Feedback activity Edit second feedback questions, add following: Q3. Short answer text Page break Q4. Short answer text Test Open two browser tabs In the first tab open Feedback activity 1 and press Answer the questions In the second tab open Feedback activity 2 and press Answer the questions In the first tab, answer Q1 and press Next page In the second tab, answer Q3 and press Next page In the first tab, answer Q2 and press Submit your answers In the second tab, answer Q4 and press Submit your answers Confirm you were able to submit both sets of answers Log out Log in as admin Navigate to Feedback activity 1 Press Responses Press Response number: 1 Confirm you see the previously entered response for Q1 & Q2 Navigate to Feedback activity 2 Press Responses Press Response number: 1 Confirm you see the previously entered response for Q3 & Q4
Pre-check results:
Hide

Code verified against automated checks.

Checked MDL-72956 using repository: https://github.com/paulholden/moodle/

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-72956-405 | CI Job]

MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-72956-500 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-72956 | CI Job]

_{More information about this report}

Built on: Wed May 14 08:58:25 UTC 2025
Show
Code verified against automated checks. Checked MDL-72956 using repository: https://github.com/paulholden/moodle/ MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-72956-405 | CI Job ] MOODLE_500_STABLE (0 errors / 0 warnings) [branch: MDL-72956-500 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-72956 | CI Job ] More information about this report Built on: Wed May 14 08:58:25 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch MDL-72956-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19440/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66518/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66519/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-72956-500

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19441/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66520/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66521/ Behat (Firefox - boost)

Launching automatic jobs for branch MDL-72956

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19442/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66522/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66523/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66524/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66525/ App tests (stable app version)

Built on: Fri May 23 20:30:23 UTC 2025
Show
Launching automatic jobs for branch MDL-72956 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19440/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66518/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66519/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-72956 -500 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19441/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66520/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66521/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-72956 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/19442/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66522/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66523/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66524/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/66525/ App tests (stable app version) Built on: Fri May 23 20:30:23 UTC 2025

If you start two survey submissions at the same time, the second one you submit will cause an error.

To replicate

As teacher
Create Feedback A
Add any question type
Create Feedback B
Add any question type

As student
In one tab, open Feedback A - make a selection BUT DO NOT SUBMIT
In another tab, open survey B - make a selection BUT DO NOT SUBMIT
Go back to the first tab and submit Feedback A
Go to the second tab and submit Feedback B

Expectation:
Both feedback submit without issues

Actual:
Feedback A submits but Feedback B shows an error message

TECHNICAL REASON FOR THIS BUG:
The reason for this bug is because of this session variable:

$SESSION->feedback->is_started

The variable tracks the status of feedback indiscriminately - i.e. it applies to ALL feedback interactions when it should only apply to an individual feedback interaction.

To fix it I'd go with something like this:

$SESSION->feedback->is_started[$cmid]

has been marked as being related by

MDL-19773 Cannot have code like $SESSION->feedback = new object(); in mod/feedback/lib.php

Closed

MDL-72424 Remove non-functional role switch check in Feedback module

Closed

Assignee:: Paul Holden

Reporter:: guy thomas

Peer reviewer:: Muhammad Arnaldo

Participants:: Amaia Anabitarte, CiBoT, guy thomas, Muhammad Arnaldo, Paul Holden

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 31/Oct/21 7:38 PM

Updated:: 26/May/25 10:24 AM

Estimated:

Not Specified

Remaining:

Logged:

1h 55m

Details

Setup

Test

Description

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify