Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72828

Generating aria labels for paging bars fails

XMLWordPrintable

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MDL-72828-master
    • Hide
      1. Log into Moodle as a teacher
      2. Navigate to your Moodle Dashboard
      3. If it isn't there already, add a Course Overview block to your page by turning on Edit mode and choosing Add a block->Course Overview
      4. Similarly to the previous step, ensure that the Timeline block is added to your Dashboard.
      5. In your browser, open developer tools and locate the Network XHR requests list.
      6. Look through these requests: /lib/ajax/service-nologin.php?info=core_get_string
      7. CONFIRM that the returned JSON response contain error:false
      Show
      Log into Moodle as a teacher Navigate to your Moodle Dashboard If it isn't there already, add a Course Overview block to your page by turning on Edit mode and choosing Add a block->Course Overview Similarly to the previous step, ensure that the Timeline block is added to your Dashboard. In your browser, open developer tools and locate the Network XHR requests list. Look through these requests: /lib/ajax/service-nologin.php?info=core_get_string CONFIRM that the returned JSON response contain error:false

      When you open a dashboard page with the myoverview or timeline block on it, you will get a failed request to /lib/ajax/service-nologin.php?info=core_get_string. It returns:

      [
        {
          "error": true,
          "exception": {
            "message": "Invalid parameter value detected",
            "errorcode": "invalidparameter",
            "link": "https://sandbox.moodledemo.net/",
            "moreinfourl": "http://docs.moodle.org/311/en/error/debug/invalidparameter"
          }
        }
      ]
      

      The request originates from: https://github.com/moodle/moodle/blob/385938b472038a423bf51774f3adfb4dff61d1e6/lib/amd/src/paged_content_paging_bar.js#L430

      The request is being made without a stringid which is required for core_get_string. The reason for the missing stringid is that a jQuery object is being passed to Str.get_strings() instead of an array. The map function works differently for those.

        1. ss_error stable_master.png
          204 kB
          David Woloszyn
        2. MDL-72828_master.mp4
          748 kB
          Angelia Dela Cruz
        3. MDL-72828_v311.mp4
          615 kB
          Angelia Dela Cruz
        4. MDL-72828_v400.mp4
          498 kB
          Angelia Dela Cruz

            david.woloszyn@moodle.com David Woloszyn
            tschroeder Tim Schroeder
            David Woloszyn David Woloszyn
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Angelia Dela Cruz Angelia Dela Cruz
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 50 minutes
                4h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.