Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72626

Bug in RTLCSS prevents SCSS compilation

XMLWordPrintable

    • MOODLE_311_STABLE, MOODLE_400_STABLE
    • MOODLE_311_STABLE
    • MDL-72626-master
    • Hide
      1. Edit theme/boost/scss/moodle/admin.scss and, for the .formtable tbody th element, add the following: "transform-origin: top; border-radius: 100px / 10px;": 

        .formtable tbody th {
        		 
            font-weight: normal;
        		 
            text-align: right;
        		 
            transform-origin: top;
        		 
            border-radius: 100px / 10px;
        		 
        }

      2. Run php admin/cli/build_theme_css.php --themes=boost -v
      3. Check no error is raised.
      Show
      Edit theme/boost/scss/moodle/admin.scss and, for the .formtable tbody th element, add the following: " transform-origin: top; border-radius: 100px / 10px; ": .formtable tbody th { font-weight: normal; text-align: right; transform-origin: top; border-radius: 100px / 10px; } Run php admin/cli/build_theme_css.php --themes=boost -v Check no error is raised.
    • Moppies Kanban

      The file lib/rtlcss/RTLCSS.php on line 358 generates a notice when i compile my theme.

      == Build theme css ==
      PHP Notice: Undefined offset: 1

      the issue is that

      $value = $parts[1];

      but there is no check in the line above to ensure that $parts is an array with 2 or more elements.

      suggest changing: 

      if (!is_object($value) && preg_match('/top|bottom/i', $value)) {

      to:

      if (!is_object($value) && preg_match('/top|bottom/i', $value) && count($parts)>1) {

       

        1. MDL-72626_Test Passed.PNG
          25 kB
          Gladys Basiana

            sarjona Sara Arjona (@sarjona)
            pgee Peter Gee
            Amaia Anabitarte Amaia Anabitarte
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 35 minutes
                1h 35m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.