Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72547

Role event log descriptions need improving

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Major Major
    • None
    • 3.10.6, 4.0.1
    • Logging
    • MOODLE_310_STABLE, MOODLE_400_STABLE
    • Hide

      Difficulty: easy, requires admin access

      1. Log in as admin and to go "Site Administration > Users > Permissions > Define roles"
      2. Go to the "Allow role overrides" report
      3. Change the state of one of the checkboxes (e.g. in the Manager row, deselect the Non-editing teacher checkbox)
      4. Save changes
      5. Go to "Site Administration > Reports > Reports > Live logs"
      6. VERIFY there is an event for "Allow role override".
      7. VERIFY the description for the event contains correct information: For example, if user (id: 2) changed the Manager role (id: 1) to not allow overriding for the Non-editing teacher role (id: 4), then the message should be similar to "The user with id '2' modified the role with id '1' to stop allowing users with that role to set overrides for the role with id '4'.")

      Repeat for the other reports:

      • Allow role assignments
      • Allow role switches
      • Allow role to view
      Show
      Difficulty: easy, requires admin access Log in as admin and to go "Site Administration > Users > Permissions > Define roles" Go to the "Allow role overrides" report Change the state of one of the checkboxes (e.g. in the Manager row, deselect the Non-editing teacher checkbox) Save changes Go to "Site Administration > Reports > Reports > Live logs" VERIFY there is an event for "Allow role override". VERIFY the description for the event contains correct information: For example, if user (id: 2) changed the Manager role (id: 1) to not allow overriding for the Non-editing teacher role (id: 4), then the message should be similar to "The user with id '2' modified the role with id '1' to stop allowing users with that role to set overrides for the role with id '4'.") Repeat for the other reports: Allow role assignments Allow role switches Allow role to view

      When I change the roles a given role is allowed to assign, the description given in the log is the reverse of what I did. This happens regardless of if I modify a role directly or if I use the "Allow role assignments" tool.

      For example, if a user (with id: 2) modifies the Manager role (id: 1) to not allow it to assign the Non-editing teacher role (id: 4)

      What I expect to show up in the log:

      The user with id '2' modified the role with id '1' to stop allowing users with that role from assigning the role with id '4' to users

      What actually shows up in the log:

      The user with id '2' modified the role with id '4' to stop allowing users with that role from assigning the role with id '1' to users

      Update: Following a discussion in the issue comments, we decided that the role event log descriptions were correct, though not easy to understand. Thus, the issue fix is improving the log description wordings.

        1. 2022-05-26T175314Z634.png
          2022-05-26T175314Z634.png
          24 kB
        2. Screenshot 2021-09-10 100245.png
          Screenshot 2021-09-10 100245.png
          43 kB

            matt.rice Matt Rice
            matt.rice Matt Rice
            Simey Lameze Simey Lameze
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 24 minutes
                3h 24m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.