Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72124

Core question events give the wrong URL

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.0.8, 4.1.3
    • 3.10.4, 3.11, 4.0.7, 4.1.2
    • Questions
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
    • MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-72124_401_STABLE
    • MDL-72124_master
    • Hide
      1. Log in as admin
      2. From the site homepage Go to the Question Bank
      3. Select "Categories" from the jump list and add a new category called "System 2" with the parent "Default for System"
      4. Select "Questions" from the jump list, go to the "Default for System" category, and create a new question called "Question 1", it can be any type, and press "Save changes"
      5. Tick the Bulk Actions checkbox next to "Question 1", then select "With selected > Move to..."
      6. Move the question to the "System 2" category.
      7. Access the logs report at /report/log/index.php and click "Get these logs".
      8. Find the "Question moved" event and click the linked text in the "Event name" column.
        • You should be taken to "System 2" category in the question bank, with "Question 1" in place.
        • Before fix: You were taken to /question/bank/managecategories/category.php, and an error was displayed.
      9. Select "Export" from the jump list and select "System 2" category for export in Moodle XML format. Click "Export questions to file"
      10. Once the export has downloaded, access the logs report at /report/log/index.php and click "Get these logs".
      11. Find the "Questions exported" event and click the linked text in the "Event name" column.
        • You should be taken to "System 2" category in the question bank
        • Before fix: You were taken to /question/bank/managecategories/category.php, and an error was displayed.
      12. Select "Categories" from the jump list and delete "System 2" category.
      13. Select "Import" from the jump list and import the downloaded export XML.
      14. Once the import is complete, access the logs report at /report/log/index.php and click "Get these logs".
      15. Find the "Questions imported" event and click the linked text in the "Event name" column.
        • You should be taken to the restored "System 2" category in the question bank
        • Before fix: You were taken to /question/bank/managecategories/category.php, and an error was displayed.
      Show
      Log in as admin From the site homepage Go to the Question Bank Select "Categories" from the jump list and add a new category called "System 2" with the parent "Default for System" Select "Questions" from the jump list, go to the "Default for System" category, and create a new question called "Question 1", it can be any type, and press "Save changes" Tick the Bulk Actions checkbox next to "Question 1", then select "With selected > Move to..." Move the question to the "System 2" category. Access the logs report at /report/log/index.php and click "Get these logs". Find the "Question moved" event and click the linked text in the "Event name" column. You should be taken to "System 2" category in the question bank, with "Question 1" in place. Before fix: You were taken to /question/bank/managecategories/category.php, and an error was displayed. Select "Export" from the jump list and select "System 2" category for export in Moodle XML format. Click "Export questions to file" Once the export has downloaded, access the logs report at /report/log/index.php and click "Get these logs". Find the "Questions exported" event and click the linked text in the "Event name" column. You should be taken to "System 2" category in the question bank Before fix: You were taken to /question/bank/managecategories/category.php, and an error was displayed. Select "Categories" from the jump list and delete "System 2" category. Select "Import" from the jump list and import the downloaded export XML. Once the import is complete, access the logs report at /report/log/index.php and click "Get these logs". Find the "Questions imported" event and click the linked text in the "Event name" column. You should be taken to the restored "System 2" category in the question bank Before fix: You were taken to /question/bank/managecategories/category.php, and an error was displayed.

      While reviewing MDL-71585, which did a like-for-like update of the URLs in the event classes like lib/classes/event/question_base.php, I noticed that these URLs are wrong.

      Near the end of the Moodle 4.0 Question bank project, we should review these event classes, and fix the URLs to take people to a sensible place in the new UI to see the effects of each change that was logged..

        1. 400.gif
          2.42 MB
          Ron Carl Alfon Yu
        2. 401.gif
          2.17 MB
          Ron Carl Alfon Yu
        3. master.gif
          2.22 MB
          Ron Carl Alfon Yu

            marxjohnson Mark Johnson
            timhunt Tim Hunt
            Tim Hunt Tim Hunt
            Paul Holden Paul Holden
            Ron Carl Alfon Yu Ron Carl Alfon Yu
            Votes:
            1 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 51 minutes
                1h 51m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.