Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-72003

Missing argument in deprecated course format renderer methods

XMLWordPrintable

    • MOODLE_400_STABLE
    • MDL-72003-master
    • Hide
      1. Install third party 3.11 course format from plugin database E.g. Soft course course format.
      2. Turn on debugging.
      3. Create course with course format set to third party format.
      4. Save and return to main course page.
      5. Turn editing on.
      6. Verify that deprecation messages are visible. For instance: 

        Method print_multiple_section_page is deprecated,

      7. Verify that coding exception is NOT shown. 

        Warning: method_exists() expects exactly 2 parameters, 1 given

         

      Show
      Install third party 3.11 course format from plugin database E.g.  Soft course  course format. Turn on debugging. Create course with course format set to third party format. Save and return to main course page. Turn editing on. Verify that deprecation messages are visible. For instance: Method print_multiple_section_page is deprecated, Verify that coding exception is NOT shown. Warning: method_exists() expects exactly 2 parameters, 1 given  

      Course format renderer methods print_single_section_page and print_multiple_section_page were deprecated lately in master. In addition to the deprecation message, the code trows an exception because an argument is missing from method_exists function. This will prevent correct renderering of formats that implement the methods being checked.

      To reproduce you should try a third party course format that works in 3.11 (e.g. format_etask), but has not been update for new renderer. 

        1. MDL-72003 after.png
          97 kB
          Simey Lameze
        2. MDL-72003 before.png
          108 kB
          Simey Lameze

            dthies Daniel Thies
            dthies Daniel Thies
            Simey Lameze Simey Lameze
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 50 minutes
                1h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.