Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71391

Plugin installer installs broken plugin ends up breaking Moodle server

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.9.6, 3.10.3, 3.11, 4.0
    • Installation
    • MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
    • MDL-71391-master3
    • Hide
      1. Prepare a broken Moodle plugin which includes non-existent file (this time '/lib/eventslib.php' which existed in 3.5 but not in 3.9 after) in lib.php of its own.
      2. Login as Admin.
      3. Install a prepared broken Moodle plugin.
      4. Confirm that installation failed and an error is displayed that "brokenplugin/lib.php includes non-existent file /lib/eventslib.php Error".
      Show
      Prepare a broken Moodle plugin which includes non-existent file (this time '/lib/eventslib.php' which existed in 3.5 but not in 3.9 after) in lib.php of its own. Login as Admin. Install a prepared broken Moodle plugin. Confirm that installation failed and an error is displayed that "brokenplugin/lib.php includes non-existent file /lib/eventslib.php Error".

      If plugin includes non-existent file in its own lib.php, installation succeeds and breaks Moodle.

      I will write a patch for this which works if plugin has a line which points non-existent file in its own lib.php, make it an error and never allow to be installed.

        1. mod_brokenplugin_2021033000.zip
          21 kB
        2. patched_installer.png
          patched_installer.png
          31 kB

            intrajp Shintaro Fujiwara
            intrajp Shintaro Fujiwara
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.