Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-71144

Deprecate the *_get_completion_state() callbacks

XMLWordPrintable

    • 1
    • Internationals - 3.11 Sprint 9

      With the activity_custom_completion base class being implemented by activity modules supporting custom completion rules, it is time to deprecate these callbacks as they won't be used anymore.

      A possible approach to do the deprecation:

      1. Add a debugging message that these callbacks are now being deprecated in completion_info::internal_get_state()
      2. Move these callbacks to the plugin's deprecatedlib.php. E.g. in assign, move to mod/assign/deprecatedlib.php. Make sure that deprecatedlib.php is included in the plugin's lib.php
      3. Add the related PHPDoc block tags (e.g. @deprecated, @todo, @see) to the *_get_completion_state() callbacks.
      4. Note the deprecation of these callbacks in upgrade.txt

            rezaie9 Shamim Rezaie
            jpataleta Jun Pataleta
            Michael Hawkins Michael Hawkins
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 2 days, 2 hours, 50 minutes
                2d 2h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.