Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.11
Affects Version/s: 3.10.1, 3.11, 4.0
Component/s: General
Labels:
- ci

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE
Epic Link:
Prepare Moodle for PHP 8.0
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
~~MDL-70898~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/41037efa7a...MDL-70898-master
Testing Instructions:

Hide

Run automated tests

Show
Run automated tests

PHP 8.0 shows a warning:

PHP Warning:  Private methods cannot be final as they are never overridden by other classes

See also https://php.watch/versions/8.0/final-private-function#final-private
there is an exception for final private __construct() and there is one constructor like that in moodle still

has a non-specific relationship to

MDL-71011 Update ADOdb to v5.21.0 and make it PHP 8.0 compliant (final & private ban)

Closed

Assignee:: Marina Glancy

Reporter:: Marina Glancy

Peer reviewer:: Amaia Anabitarte

Integrator:: Eloy Lafuente (stronk7)

Tester:: CiBoT

Participants:: Amaia Anabitarte, CiBoT, Eloy Lafuente (stronk7), Marina Glancy

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 15/Feb/21 10:57 PM

Updated:: 05/Mar/21 11:38 PM

Resolved:: 05/Mar/21 11:38 PM

Estimated:

Not Specified

Remaining:

0m

Logged:

3h 10m