Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70731

Harcoded error in forum discuss.php

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.11.7
    • 3.8.7
    • Forum
    • MOODLE_38_STABLE
    • MOODLE_311_STABLE
    • MDL-70731-master
    • Hide
      1. Paste on your browser address bar: [YOUR_MOODLE_INSTANCE]/mod/forum/discuss.php?d=[NONEXISTENT_DISCUSSION_ID]
      2. Confirm that you don't get a PHP Warning about an undefined variable.
      3. Confirm that you get an error message that says the discussion was not found.
      Show
      Paste on your browser address bar: [YOUR_MOODLE_INSTANCE] /mod/forum/discuss.php?d= [NONEXISTENT_DISCUSSION_ID] Confirm that you don't get a PHP Warning about an undefined variable. Confirm that you get an error message that says the discussion was not found.

      In mod/forum/discuss.php there are some hardcoded error strings, and the first one (line 48) has an undefined variable (discussionid).

      The users sometimes see this error : for example when they received a notification of a new forum post, the post is deleted but they still have the notification. If they click on it, they arrive at that page with that error. It seams a little too technical for them, and not in their language.

      For that reason, it would be better if the string was not hardcoded, and could be translated.

        1. 311_Screenshot.PNG
          55 kB
          Gladys Basiana
        2. image-2021-01-28-10-55-30-253.png
          40 kB
          Marie-Eve Lévesque
        3. Master_Screenshot.PNG
          45 kB
          Gladys Basiana

            jpataleta Jun Pataleta
            levemar Marie-Eve Lévesque
            Adrian Greeve Adrian Greeve
            Andrew Lyons Andrew Lyons
            Gladys Basiana Gladys Basiana
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.