Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-70290

Upgrade HTML Purifier to 4.13.0

XMLWordPrintable

    • MOODLE_310_STABLE
    • MOODLE_311_STABLE
    • MDL-70290-master
    • Hide

      Test 1

      1. Log in as Admin.
      2. Create a Course.
      3. Enrol a Student in the Course.
      4. Create a Forum in the Course.
      5. Log in the Student.
      6. Go to the Forum.
      7. Create a discussion.
      8. In the discussion message, add a couple of HTML links with "Open in new window" checked and a couple with "Open in new window" unchecked.
      9. Save.
      10. View the discussion and verify, viewing source code, that any links that have the "target="xxxx"" attribute will have "rel=noreferrer noopener" attribute added.
      11. Make sure when opening a target="_blank" link that the original page is not redirected and the link is open in a new tab/window.
      12. Try the same sort of thing in other text areas and see if any don't add the attribute.

      Example:

      This:
      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>
       
      Becomes:
      <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer noopener">Test my link</a>

       

      Test 2

      (No manual test is required here): Run all unit tests and check that failures don't relate to this issue.

      Show
      Test 1 Log in as Admin. Create a Course. Enrol a Student in the Course. Create a Forum in the Course. Log in the Student. Go to the Forum. Create a discussion. In the discussion message, add a couple of HTML links with "Open in new window" checked and a couple with "Open in new window" unchecked. Save. View the discussion and verify , viewing source code, that any links that have the " target="xxxx" " attribute will have " rel=noreferrer noopener " attribute added. Make sure  when opening a target="_blank" link that the original page is not redirected and the link is open in a new tab/window. Try the same sort of thing in other text areas and see if any don't add the attribute. Example: This: <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank">Test my link</a>   Becomes: <a href="http://allthethings.co.nz/moodle/redirect.html" target="_blank" rel="noreferrer noopener">Test my link</a>   Test 2 (No manual test is required here): Run all unit tests and check that failures don't relate to this issue.
    • 3
    • 4.0 holding pattern 10

      HTML Purifier (/lib/htmlpurifier/) 4.12.0 --> 4.13.0 :  http://htmlpurifier.org/ 

            peterdias Peter Dias
            sarjona Sara Arjona (@sarjona)
            Glyn (Mathew) May Glyn (Mathew) May
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 30 minutes
                1h 30m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.