-
Bug
-
Resolution: Unresolved
-
Minor
-
None
-
3.7.8, 3.8.5, 3.9.2, 3.10
-
MOODLE_310_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
We should only be accepting tokens sent to an account's current email address, so when a user's email account is updated, we should invalidate tokens used in password reset (forgotten password) links sent to the old address. (It would be worth also having a look for any other similar tokens that may need similar treatment.)
We should also be removing existing tokens if a new one is generated (ie another forgot password request for the account is received).
Given the (default) short life of such tokens and the fact that they are single use, these are fairly edge case, but is a valid fix to comply with security best practice. Taking that into account along with the low risk of being an exploitable issue, I've marked this as a security benefit, and not assigned a security level.
For consistency, we should also invalidate forgot password tokens if the password is changed, regardless of method..
Written up by michaelh, based on reports by vivnat, saurabhmhatre and others.
- has a non-specific relationship to
-
MDL-70843 Add a "Log out after email change" site administration setting
-
- Open
-