Loading...

XML

Word

Printable

Affected Branches:
MOODLE_310_STABLE, MOODLE_311_STABLE, MOODLE_35_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE
Fixed Branches:
MOODLE_311_STABLE, MOODLE_400_STABLE
Pull from Repository:
https://github.com/paulholden/moodle.git
Pull Main Branch:
~~MDL-69939~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...paulholden:MDL-69939
Testing Instructions:
Hide

Confirm the following returns no matches:

$ git grep "'true'" -- '*.php' | grep services
Show
Confirm the following returns no matches: $ git grep "'true'" -- '*.php' | grep services

There are a couple of places which have this madness.
We must remember that:

'false' == true

See:

2049 im:master> gg "'true'" | grep php | grep service

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'        => 'true'

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'          => 'true',

lib/db/services.php:        'ajax'        => 'true',

media/player/videojs/db/services.php:        'ajax'          => 'true',

In this case they're all fine, and there are no instances of 'false', but we should still fix it.

Discovered while testing

MDL-74287 Early (web) installation steps lead to table does not exist errors

Participants:: Andrew Lyons, Angelia Dela Cruz, CiBoT, Ferran Recio, Jun Pataleta, Paul Holden, Simey Lameze

Estimated:

Not Specified

Remaining:

Logged:

1h 43m