Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-69292

"RangeError: Maximum call stack size exceeded" error when using Atto editor - causing lockups in the browser

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Won't Do
    • Icon: Minor Minor
    • None
    • 3.8.4, 3.9.1, 3.10.2
    • Text editor Atto
    • MOODLE_310_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
    • MDL-69292-master
    • Hide

      IMPORTANT: Test it using several browsers (Safari, Firefox, Chrome, Edge...).

      1. Login as admin.
      2. Create a course.
      3. Click "Turn Editing On".
      4. Click "Add activity or resource" and select "Page".
      5. Open the browser console (to confirm no error is raised).
      6. In the Atto Toolbar for the "Description" field, choose `A` (Paragraph Styles).
      7. Pick any style.
      8. Confirm no error "RangeError: Maximum call stack size exceeded." is displayed in the browser console.
      9. Typing a group of words into the editor and then highlight one of the words.
      10. Select the 'bold' symbol from the editor interface.
      11. Confirm that the word has been made bold and that the word has remained highlighted.
      12. Confirm that the cursor has remained where it was in the editor (has not lost focus).

       

      Show
      IMPORTANT: Test it using several browsers (Safari, Firefox, Chrome, Edge...). Login as admin. Create a course. Click "Turn Editing On". Click "Add activity or resource" and select "Page". Open the browser console (to confirm no error is raised). In the Atto Toolbar for the "Description" field, choose `A` (Paragraph Styles). Pick any style. Confirm no error "RangeError: Maximum call stack size exceeded." is displayed in the browser console. Typing a group of words into the editor and then highlight one of the words. Select the 'bold' symbol from the editor interface. Confirm that the word has been made bold and that the word has remained highlighted. Confirm that the cursor has remained where it was in the editor (has not lost focus).  

      We just upgraded to Moodle 3.8, and we're seeing some rather major performance issues with the Atto editor when using the Safari browser. We also see this on 3.9 (using sandbox.moodledemo.net). 

      What we're seeing is unresponsiveness and lock-ups in Atto when using Safari. For example, when writing on a page, selecting some text, the selecting the Heading toolbar icon, we see a stutter in how Atto reacts. Oftentimes, one has to wait a second or two for the change to take place. This sluggishness seems to be especially prevalent when using the Font Color toolbar. Selecting text, then selecting a color, one usually has to wait a couple seconds for the change to take place. And then, you usually can't do anything in the browser for a couple seconds or more, until it unfreezes and returns you control.

      What follows are the steps to reproduce in Safari, and I've attached stack trace results that Safari gave.

      Steps to reproduce:
      Visit https://sandbox.moodledemo.net/
      Login as: `teacher` / `sandbox`
      Click `My First Course`
      Click `Turn Editing On`
      Click `Add activity or resource`
      Click `Page`
      In the Atto Toolbar for the description field choose `A` (Paragraph Styles)
      Pick any style
      (See attachment for stack trace results).

      ******

      We are also seeing these results in Chrome (Mac), where we are seeing some lock ups (e.g., the second or third heading change triggers it and locks up for a moment. However, once the initial lock up is done the error still shows up, but performance seems fine.) But there appears to be less impact on performance in Chrome. We don't see these problems at all when using FireFox ( Mac). 

      These issues are not present at all in Moodle 3.7. They appear to have been introduced in Moodle 3.8.

      Please let me know if any of this isn't clear or if there is more information we can provide that would be helpful. 

      Thanks... Brian

       

        1. safari stack trace.txt
          4 kB

            Votes:
            21 Vote for this issue
            Watchers:
            28 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 5 hours, 31 minutes
                1d 5h 31m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.