-
Bug
-
Resolution: Fixed
-
Minor
-
3.9
-
MOODLE_39_STABLE
-
MOODLE_401_STABLE, MOODLE_402_STABLE
-
MDL-69187-401 -
- Log in as admin
- Make the following change (string accepted types):
index c7ee781ff20..a1d3d58b857 100644--- a/admin/tool/admin_presets/classes/form/import_form.php+++ b/admin/tool/admin_presets/classes/form/import_form.php@@ -43,7 +43,7 @@ class import_form extends moodleform {// File upload.$mform->addElement('filepicker', 'xmlfile',- get_string('selectfile', 'tool_admin_presets'));+ get_string('selectfile', 'tool_admin_presets'), null, ['accepted_types' => '.txt, .xml']);$mform->addRule('xmlfile', null, 'required');$this->add_action_buttons(true, get_string('import', 'tool_admin_presets')); - Navigate to Site admin presets from site administration
- Press Import preset
- Confirm you see the following:
Accepted file types:application/xml .xmlText file .txt - Upload Frog.jpg
- Confirm you see the error: "Image (JPEG) filetype cannot be accepted."
- Upload Demo.xml and press Import
- Confirm file was imported successfully
- Make the following change (array accepted types):
--- a/admin/tool/admin_presets/classes/form/import_form.php+++ b/admin/tool/admin_presets/classes/form/import_form.php@@ -43,7 +43,7 @@ class import_form extends moodleform {// File upload.$mform->addElement('filepicker', 'xmlfile',- get_string('selectfile', 'tool_admin_presets'));+ get_string('selectfile', 'tool_admin_presets'), null, ['accepted_types' => ['.txt', '.xml']]);$mform->addRule('xmlfile', null, 'required');$this->add_action_buttons(true, get_string('import', 'tool_admin_presets')); - Repeat steps 3. to 9. above, ensuring identical behaviour
Log in as admin Make the following change ( string accepted types): index c7ee781ff20..a1d3d58b857 100644 --- a/admin/tool/admin_presets/classes/form/import_form.php +++ b/admin/tool/admin_presets/classes/form/import_form.php @@ -43,7 +43,7 @@ class import_form extends moodleform { // File upload. $mform->addElement('filepicker', 'xmlfile', - get_string('selectfile', 'tool_admin_presets')); + get_string('selectfile', 'tool_admin_presets'), null, ['accepted_types' => '.txt, .xml']); $mform->addRule('xmlfile', null, 'required'); $this->add_action_buttons(true, get_string('import', 'tool_admin_presets')); Navigate to Site admin presets from site administration Press Import preset Confirm you see the following: Accepted file types: application/xml .xml Text file .txt Upload Frog.jpg Confirm you see the error: "Image (JPEG) filetype cannot be accepted." Upload Demo.xml and press Import Confirm file was imported successfully Make the following change ( array accepted types): --- a/admin/tool/admin_presets/classes/form/import_form.php +++ b/admin/tool/admin_presets/classes/form/import_form.php @@ -43,7 +43,7 @@ class import_form extends moodleform { // File upload. $mform->addElement('filepicker', 'xmlfile', - get_string('selectfile', 'tool_admin_presets')); + get_string('selectfile', 'tool_admin_presets'), null, ['accepted_types' => ['.txt', '.xml']]); $mform->addRule('xmlfile', null, 'required'); $this->add_action_buttons(true, get_string('import', 'tool_admin_presets')); Repeat steps 3. to 9. above, ensuring identical behaviour
This issue is found while trying to correct MDL-69141.
If a form specifies the valid extensions in the file picker as:
$options['accepted_types'] = '.html, .txt'; |
The file picker does not show the valid extensions to the user and the form can be submitted
but, if the user tries to upload (and submit the form) an invalid file gets an inline red error:
On the other hand, if the same form specifies the extensions like this:
$options['accepted_types'] = ['.html', '.txt']; |
The file picker shows the valid extensions correctly
but, when the user uploads an invalid file, get a modal error instantly:
Possible solutions
- Unify the error messages format to have a coherent UX
- In both string or array accepted_type, the file picker should show the valid extensions under the file picker.
- Discovered while testing
-
-
- Closed
-
- Testing discovered
-
-
- Closed
-
- will help resolve
-
-
- Open
-
