Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68655

Investigate phpunit failures with php74 + oracle

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: Minor Minor
    • None
    • 3.8.2, 3.9
    • Unit tests
    • None
    • MOODLE_38_STABLE, MOODLE_39_STABLE

      This comes from MDL-66260 (PHP 7.4 epic).

      It has been detected that phpunit + php74 + oracle is behaving strangely / randomly, leading to a lot of failures without apparent explanation.

      Link: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/837/

      In the other side, local runs are mostly passing (there is 1 error and 1 failure, but likely it's my testing environment).

      Link: https://pastebin.com/g9jq0YB5

      The same runs with any other database or any other php version pass without problems.

      So initial target was to review that all the oracle-specific code (database driver) was php74 compliant. And it seems it is.

      Worth mentioning that the very same combination of php74 + oracle is passing all behat tests without any problem.

      So we need to investigate why this failures are happening. Could the docker images, could be some bogus test that is causing troubles at distance...

      TODO1: Whenever we get this fixed, make all oracle phpunit jobs @ CI to go back to "highest".
      TODO2: Also enable 38_STABLE highest to be PHP 7.4.
      TODO3: Decide which database should be using intermediate PHP versions (right now PHP 7.3 in master).

            stronk7 Eloy Lafuente (stronk7)
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.