Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68569

static method customfield_select\field_controller::get_options_array()

XMLWordPrintable

    • MOODLE_39_STABLE
    • MOODLE_310_STABLE
    • Hide

      Run automated tests (similar to MDL-66135)

      1. Init phpunit, then run vendor/bin/phpunit --testsuite core_customfield_testsuite,customfield_select_testsuite
        1. Verify it ends without errors.
      2. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can update courses using a CSV file"
        1. Verify it ends without errors.
      3. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can create courses using a CSV file"
        1. Verify it ends without errors.
      Show
      Run automated tests (similar to MDL-66135 ) Init phpunit, then run vendor/bin/phpunit --testsuite core_customfield_testsuite,customfield_select_testsuite Verify it ends without errors. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can update courses using a CSV file" Verify it ends without errors. Init behat, then run admin/tool/behat/cli/run.php --name="An admin can create courses using a CSV file" Verify it ends without errors.

      From MDL-66135:

      ... but it called the attention like crazy to me, is there any reason for \ customfield_select\field_controller::get_options_array() to be static? It's the only static stuff within custom fields and, unless I'm wrong, all its uses are from instantiated places.

      This is about to consider if there is any reason for it to be static and proceed to make it a normal instance method instead.

      Ciao

        1. MDL-68569.jpg
          MDL-68569.jpg
          95 kB

            pholden Paul Holden
            stronk7 Eloy Lafuente (stronk7)
            Peter Dias Peter Dias
            Andrew Lyons Andrew Lyons
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 57 minutes
                3h 57m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.