-
Bug
-
Resolution: Fixed
-
Minor
-
3.7.5, 3.7.7, 3.8.2, 3.8.4, 3.9, 3.9.1
-
MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE
-
MOODLE_401_STABLE, MOODLE_402_STABLE
-
MDL-68435-401 -
- Log in as admin
- Navigate to Courses > Course custom fields in site administration
- Press Add a new category (if none already exist)
- Add a new custom field of type Text area
- Name: My field
- Short name: myfield
- Enter some text in the description field, highlight it and press Insert > Link in the editor
- Press Browse repositories and upload My document.pdf
- Press Save changes to create the custom field
- Navigate to Courses > Add a new course
- Choose a name and short name
- Expand Other fields
- Right click on the link in the description of your custom My field and press Save link as (or your local browser equivalent)
- Confirm that the filename prompt shows My document.pdf and not a number
- Enter some text in the My field textarea, highlight it and press Insert > Link in the editor
- Press Browse repositories and upload My document.pdf
- Press Save and display to create the course
- Manually navigate to <WWWROOT>/course/index.php
- Right click on the link in the text of your custom My field and press Save link as (or your local browser equivalent)
- Confirm that the filename prompt shows My document.pdf and not a number
Log in as admin Navigate to Courses > Course custom fields in site administration Press Add a new category (if none already exist) Add a new custom field of type Text area Name: My field Short name: myfield Enter some text in the description field, highlight it and press Insert > Link in the editor Press Browse repositories and upload My document.pdf Press Save changes to create the custom field Navigate to Courses > Add a new course Choose a name and short name Expand Other fields Right click on the link in the description of your custom My field and press Save link as (or your local browser equivalent) Confirm that the filename prompt shows My document.pdf and not a number Enter some text in the My field textarea, highlight it and press Insert > Link in the editor Press Browse repositories and upload My document.pdf Press Save and display to create the course Manually navigate to <WWWROOT>/course/index.php Right click on the link in the text of your custom My field and press Save link as (or your local browser equivalent) Confirm that the filename prompt shows My document.pdf and not a number
Customfield textarea lib.php file implements function custofield_textarea_pluginfile. In this function file is served by calling send_file function with wrong params. This causes that served file name is always 86400.
Function call in customfield/field/textarea/lib.php looks like this:
send_file($file, 86400, 0, $forcedownload, $options);
Actual send_file function expects such params:
function send_file($path, $filename, $lifetime = null , $filter=0, $pathisstring=false, $forcedownload=false, $mimetype='',
$dontdie=false, array $options = array())
Function call in customfield/field/textarea/lib.php should be:
send_file($file, $filename, 86400, 0, false, $forcedownload, '', false, $options);
