Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-68356

H5P icon incorrectly being associated with IMSCC backups

XMLWordPrintable

    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_38_STABLE
    • MDL-68356-master
    • Hide

      Before applying the patch apply the following steps

      1. You need a clean site moodle installation without the patch.
      2. Login as an admin.
      3. Go to Private files.
      4. Upload the h5p files attached in the issue, chart.h5p and drag-and-drop.h5p.
      5. Click in Saves changes.
      6. Expected result: Confirm you could see the chat.h5p and drag-and-drop.h5p files with the h5p icon.
      7. Now, create a course empty named C1.
      8. Go to course C1 and do the backup, making sure to check/enable the 'IMS Common Cartridge 1.1' option (we don't want files because of the bug reported in MDL-67870).
      9. Once complete, click "Manage backups".
      10. In recent items, see the backup of the course and the h5p files.
      11. Expected result: Confirm you see the H5P icon for the backup of the course. You should see:

      After applying the patch

      Testing scenario 1: Check the IMSCP backups show the right icon.

      1. Login as an admin.
      2. Upgrade the site.
      3. Go to course C1 and click on Restore action.
      4. Click "Manage backups".
      5. In recent items, see the backup of the course and the h5p files.
      6. Expected result: Confirm you don't see the H5P icon for the backup of the course and you should see this:

      Testing scenario 2: Check upgrade Database existing files.

      1. Expected result: Confirm the 'files' table in the Database that the two h5p files have  'application/zip.h5p' mimetype.

       

      Show
      Before applying the patch apply the following steps You need a clean site moodle installation without the patch. Login as an admin. Go to Private files. Upload the h5p files attached in the issue, chart.h5p and drag-and-drop.h5p. Click in Saves changes. Expected result: Confirm you could see the chat.h5p and drag-and-drop.h5p files with the h5p icon. Now, create a course empty named C1. Go to course C1 and do the backup, making sure to check/enable the 'IMS Common Cartridge 1.1' option (we don't want files because of the bug reported in  MDL-67870 ). Once complete, click "Manage backups". In recent items, see the backup of the course and the h5p files. Expected result: Confirm  you see the H5P icon for the backup of the course. You should see: After applying the patch Testing scenario 1: Check the IMSCP backups show the right icon. Login as an admin. Upgrade the site. Go to course C1 and click on Restore action. Click "Manage backups". In recent items, see the backup of the course and the h5p files. Expected result: Confirm  you don't see the H5P icon for the backup of the course and you should see this: Testing scenario 2: Check upgrade Database existing files. Expected result: Confirm the 'files' table in the Database that the two h5p files have  'application/zip.h5p' mimetype.  

      This one is pretty easy to see in action:
      1. Backup an empty course, making sure to check/enable the IMSCC option (we don't want files because of the bug reported in MDL-67870)
      2. Once complete, click "Manage backups"
      3. In recent items, see the backup.imscc
      Expected: it has a non-H5P icon
      Actual: It has an H5P icon like this:

        1. chart.h5p
          107 kB
          Carlos Escobedo
        2. drag-and-drop.h5p
          994 kB
          Carlos Escobedo
        3. h5p_backups_icon.jpg
          23 kB
          Jake Dallimore
        4. image-2020-04-07-15-50-26-165.png
          36 kB
          Carlos Escobedo
        5. MDL-68356_AfterPatch.jpg
          36 kB
          Anna Carissa Sadia
        6. MDL-68356_BeforePatch.jpg
          37 kB
          Anna Carissa Sadia
        7. Screenshot 2020-04-07 at 15.47.07.png
          42 kB
          Carlos Escobedo

            cescobedo Carlos Escobedo
            jaked Jake Dallimore
            Amaia Anabitarte Amaia Anabitarte
            Jun Pataleta Jun Pataleta
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 7 hours, 10 minutes
                7h 10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.