Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.8.3
Affects Version/s: 3.9
Component/s: H5P
Labels:

Affected Branches:
MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Epic Link:
H5P for Moodle 3.9
Pull from Repository:
git://github.com/cescobedo/moodle.git
Pull Main Branch:
~~MDL-68285~~-master
Pull Main Diff URL:
https://github.com/cescobedo/moodle/compare/d939d6e769...MDL-68285-master
Testing Instructions:
Hide

We need to be sure that all H5P is working after this change. To do that, just we need to run all the Unit Test for h5p and Behat test with this tag @core_h5p and this testsuite core_h5p_testsuite.

Covered by unit tests (PHPUnit and Behat):

master

Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5319/

PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/774/

38

Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5320/

PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/775/
Show
We need to be sure that all H5P is working after this change. To do that, just we need to run all the Unit Test for h5p and Behat test with this tag @core_h5p and this testsuite core_h5p_testsuite. Covered by unit tests (PHPUnit and Behat): master Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5319/ PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/774/ 38 Behat: https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/5320/ PHPUnit: https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/775/

Just a few I noticed in master:

$factory in get_scripts() - unused
$tempfile in fetch_content_types() - unused
$CFG in get_latest_content_types - undeclared

Assignee:: Carlos Escobedo

Reporter:: Jake Dallimore

Peer reviewer:: Jake Dallimore

Integrator:: Andrew Lyons

Tester:: CiBoT

Participants:: Andrew Lyons, Carlos Escobedo, CiBoT, Jake Dallimore

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Created:: 30/Mar/20 1:18 PM

Updated:: 04/May/20 9:46 PM

Resolved:: 08/Apr/20 11:21 PM

Estimated:

Not Specified

Remaining:

Logged:

55m

Details

Description

Attachments

Activity

People

Dates

Time Tracking

Clockify