Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67921

Review getOption implementation in H5P Framework

XMLWordPrintable

      The implementation we did in framework.php for getOption method is not valid, because it should return the stored setting with $name (or $default if it's not found) instead of \H5PDisplayOptionBehaviour::CONTROLLED_BY_AUTHOR_DEFAULT_OFF.

      This value (\H5PDisplayOptionBehaviour::CONTROLLED_BY_AUTHOR_DEFAULT_OFF) should be returned only, at least for now, for DISPLAY_OPTION_DOWNLOAD and DISPLAY_OPTION_EMBED.

            sarjona Sara Arjona (@sarjona)
            sarjona Sara Arjona (@sarjona)
            Carlos Escobedo Carlos Escobedo
            Jun Pataleta Jun Pataleta
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 4 hours, 50 minutes
                4h 50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.