Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67583

Popover placement should react to scroll event

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.7.5, 3.8.2
    • 3.8, 3.9
    • Themes
    • MOODLE_38_STABLE, MOODLE_39_STABLE
    • MOODLE_37_STABLE, MOODLE_38_STABLE
    • MDL-67583-master
    • Hide
      • Navigate to any page that has a help icon (e.g: course edit page), scroll the browser to make sure the help icon is at the middle of the screen
      • Click on the help icon, check that the dialog is at the right side of the icon.
      • Scroll the browser down to make the icon closer to the browser top edge, check that dialog is at the bottom of the icon.
      • Scroll the browser up to make the icon closer to the browser bottom edge, check that dialog is at the top of the icon.
      Show
      Navigate to any page that has a help icon (e.g: course edit page), scroll the browser to make sure the help icon is at the middle of the screen Click on the help icon, check that the dialog is at the right side of the icon. Scroll the browser down to make the icon closer to the browser top edge, check that dialog is at the bottom of the icon. Scroll the browser up to make the icon closer to the browser bottom edge, check that dialog is at the top of the icon.

      Currently, when clicking on help icon, the popover popup always show at the right side of the icon no matter where the element is, sometime, the element is too close to header, footer or the edge of the browser that cut off the dialog's content.

      So I think this dialog should aware of it position react to user scroll event, normally it's will display at the right side like it is now, when user scroll, it will react and change position to top or bottom, also this can be achieve by just adding a Bootstrap parameter.

      I've attached the result after adding new parameter (placement: 'auto').

        1. close-to-bottom-edge.png
          21 kB
          Kiet Ly
        2. Normal.png
          34 kB
          Kiet Ly
        3. close-to-top-edge.png
          29 kB
          Kiet Ly
        4. MDL-67583.jpg
          61 kB
          Anna Carissa Sadia

            kietlyc Kiet Ly
            kietlyc Kiet Ly
            Adrian Greeve Adrian Greeve
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 hour, 5 minutes
                1h 5m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.