Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-67526

Final deprecation of plagiarism functions

XMLWordPrintable

    • Icon: Task Task
    • Resolution: Fixed
    • Icon: Minor Minor
    • 4.2
    • 4.2
    • Plagiarism
    • MOODLE_402_STABLE
    • MOODLE_402_STABLE
    • MDL-67526_final-deprecation-of-plagiarism-functions
    • Hide
      1. Make sure all unit test passes (CiBot)
      2. Review code and confirm the functions are deprecated properly.
      3. Search through the code and confirm that plagiarism_save_form_elements() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt)
      4. Search through the code and confirm that plagiarism_get_form_elements_module() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt)
      5. Search through the code and confirm that plagiarism_plugin::get_form_elements_module() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt)
      6. Search through the code and confirm that plagiarism_plugin::save_form_elements() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt)
      7. Search through code and confirm that there are no more TODOS or mentions of MDL-67526.
      Show
      Make sure all unit test passes (CiBot) Review code and confirm the functions are deprecated properly. Search through the code and confirm that plagiarism_save_form_elements() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt ) Search through the code and confirm that plagiarism_get_form_elements_module() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt ) Search through the code and confirm that plagiarism_plugin::get_form_elements_module() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt ) Search through the code and confirm that plagiarism_plugin::save_form_elements() is not used anywhere. (except in the function declaration in lib/deprecatedlib.php and the upgrade note in lib/upgrade.txt ) Search through code and confirm that there are no more TODOS or mentions of MDL-67526 .

      Do the final deprecation of:

      • plagiarism_save_form_elements()
      • plagiarism_get_form_elements_module()
      • plagiarism_plugin::get_form_elements_module()
      • plagiarism_plugin::save_form_elements()

      The first two files need to be moved into deprecatedlib.php and the body of the function removed. The second two methods just need to be removed.
      Code calling these functions should be removed from mod_assign, mod_forum, and mod_workshop.

      plagiarism_load_available_plugins method should be deprecated too.

        1. (I) Passed -- (Master)MDL-67526.png
          (I) Passed -- (Master)MDL-67526.png
          130 kB

            Daniel Ziegenberg Daniel Ziegenberg
            abgreeve Adrian Greeve
            Paul Holden Paul Holden
            Ferran Recio Ferran Recio
            Kim Jared Lucas Kim Jared Lucas
            Votes:
            0 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 3 hours, 15 minutes
                3h 15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.