Loading...

XML

Word

Printable

Affected Branches:
MOODLE_38_STABLE, MOODLE_39_STABLE
Fixed Branches:
MOODLE_38_STABLE
Pull from Repository:
git://github.com/marinaglancy/moodle.git
Pull Main Branch:
~~MDL-67523~~-master
Pull Main Diff URL:
https://github.com/marinaglancy/moodle/compare/6aacd8d6d1...MDL-67523-master
Testing Instructions:
Hide

Assign role "Manager" to a user in the system context

Log in as this user

Go to Site administration

Click on categories names (i.e. "Users", "Badges", etc), make sure they display the list of subsections and only the subsections available to this user are displayed

Login as admin and find some category that is not available for the Manager, for example "Plugins>Activity modules", copy the URL

Login as manager and go to this URL, make sure you see an error
Show
Assign role "Manager" to a user in the system context Log in as this user Go to Site administration Click on categories names (i.e. "Users", "Badges", etc), make sure they display the list of subsections and only the subsections available to this user are displayed Login as admin and find some category that is not available for the Manager, for example "Plugins>Activity modules", copy the URL Login as manager and go to this URL, make sure you see an error

Assign role "Manager" to a user in the system context
Log in as this user
Go to Site administration
All sections names are displayed as links but clicking on them shows an exception

Sorry, but you do not currently have permissions to do that (Change site configuration).

More information about this error

Debug info:

Error code: nopermissions

Stack trace:

    line 860 of /lib/accesslib.php: required_capability_exception thrown

    line 3064 of /lib/moodlelib.php: call to require_capability()

    line 33 of /admin/category.php: call to require_admin()

We either need to not throw an exception or not show them as links

category_Link_works_and_shows_allowed_sections.png
30/Dec/19 6:46 AM
21 kB
Eloy Lafuente (stronk7)
forbidden_secion_throws_error.png
30/Dec/19 6:46 AM
34 kB
Eloy Lafuente (stronk7)

is a regression caused by

MDL-58439 Admin pages login as guest and then throw Access denied error (should prompt for login) require_admin()

mentioned on

Participants:: CiBoT, Eloy Lafuente (stronk7), Gitlab MoodleCloud, Marina Glancy, Paul Holden

Estimated:

Not Specified

Remaining:

Logged:

1h 5m