Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66820

Double escaped quotes in timeline block

XMLWordPrintable

    • MOODLE_311_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE, MOODLE_39_STABLE, MOODLE_400_STABLE, MOODLE_401_STABLE
    • MDL-66820-401
    • MDL-66820-master
    • Hide
      1. Log in to Moodle as an Admin.
      2. Create a course and add two assignment activities with these names: A "quote" assignment  and  A \backslash\ assignment
      3. Enrol a student into the course
      4. Log in as the student
      5. Navigate to the Dashboard.
      6. CONFIRM that there is no JSON parse error popup.
      7. CONFIRM that the timeline loads in the two assignments with the correct names.
      8. Using your browser's code inspector, inspect the link of each assignment.
      9. CONFIRM that the aria-label attribute of the timeline assignments correctly contains the name of the assignment.
      Show
      Log in to Moodle as an Admin. Create a course and add two assignment activities with these names: A "quote" assignment   and  A \backslash\ assignment Enrol a student into the course Log in as the student Navigate to the Dashboard. CONFIRM that there is no JSON parse error popup. CONFIRM that the timeline loads in the two assignments with the correct names. Using your browser's code inspector, inspect the link of each assignment. CONFIRM that the aria-label attribute of the timeline assignments correctly contains the name of the assignment.
    • 6
    • Team Hedgehog Sprint 1.1, Team Hedgehog Sprint 1.2

      Following MDL-66542, course or activity names with quote marks in them have a backslash escape shown when in the timeline:

      This was a known/preferred regression compared to the behavior in that ticket, but still needs to be addressed.

      I have some analysis down in the discussion.

       

        1. image-2022-11-29-15-52-43-338.png
          image-2022-11-29-15-52-43-338.png
          150 kB
        2. image-2022-11-29-15-53-26-348.png
          image-2022-11-29-15-53-26-348.png
          155 kB
        3. Screenshot 2019-10-02 10.47.03.png
          Screenshot 2019-10-02 10.47.03.png
          87 kB

            david.woloszyn@moodle.com David Woloszyn
            emerrill Eric Merrill
            Stevani Andolo Stevani Andolo
            Ilya Tregubov Ilya Tregubov
            Amaia Anabitarte Amaia Anabitarte
            Votes:
            17 Vote for this issue
            Watchers:
            26 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 1 day, 2 hours, 31 minutes
                1d 2h 31m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.