Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.9, 4.5.5, 5.0.1
Affects Version/s: 3.6.5, 3.7.1, 4.1.3
Component/s: Questions
Labels:
- ci
- triaged

Affected Branches:
MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_401_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE, MOODLE_500_STABLE
Pull from Repository:
https://github.com/danghieu1407/moodle.git
Pull 4.4 Branch:
~~MDL-66584~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...danghieu1407:moodle:MDL-66584-404
Pull 4.5 Branch:
~~MDL-66584~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...danghieu1407:moodle:MDL-66584-405
Pull Main Branch:
~~MDL-66584~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...danghieu1407:moodle:MDL-66584-master
Testing Instructions:
Hide

Setup for drag and drop onto image:

Import the attached big dd question.xmlto the question bank in a course. (Or create a Drag-drop on image question with lots of dropzone )

Go to Site administration -> Development -> Debugging

Set "Debug messages" to "DEVELOPER: extra Moodle debug messages for developers"

Set "Display debug messages" to "Yes"

Scenario 1: Preview question

Go to the question bank page -> Preview question

Scenario 2: Start attempting the quiz

Add that question to the quiz

Click Preview Quiz and start the attempt

Expected: The question should be working fine and the page doesn't show any warning errors.

Setup for drag and drop marker:

Import the attached questions-T100-Q15 DDM Places in MK-20240815-1436.xml to the question bank in a course.

Go to Site administration -> Development -> Debugging

Set "Debug messages" to "DEVELOPER: extra Moodle debug messages for developers"

Set "Display debug messages" to "Yes"

Scenario 1: Preview question

Edit question (make sure the option "Highlight drop zones which have not had the correct marker dropped on them" is ticked)

Go to the question bank page -> Preview question

Scenario 2: Start attempting the quiz

Add that question to the quiz

Click Preview Quiz and start the attempt

Finished attempt

Expected: The question should be working fine and the page doesn't show any warning errors.
Show
Setup for drag and drop onto image: Import the attached big dd question.xml to the question bank in a course. (Or create a Drag-drop on image question with lots of dropzone ) Go to Site administration -> Development -> Debugging Set "Debug messages" to "DEVELOPER: extra Moodle debug messages for developers" Set "Display debug messages" to "Yes" Scenario 1: Preview question Go to the question bank page -> Preview question Scenario 2: Start attempting the quiz Add that question to the quiz Click Preview Quiz and start the attempt Expected: The question should be working fine and the page doesn't show any warning errors. Setup for drag and drop marker: Import the attached questions-T100-Q15 DDM Places in MK-20240815-1436.xml to the question bank in a course. Go to Site administration -> Development -> Debugging Set "Debug messages" to "DEVELOPER: extra Moodle debug messages for developers" Set "Display debug messages" to "Yes" Scenario 1: Preview question Edit question (make sure the option "Highlight drop zones which have not had the correct marker dropped on them" is ticked) Go to the question bank page -> Preview question Scenario 2: Start attempting the quiz Add that question to the quiz Click Preview Quiz and start the attempt Finished attempt Expected: The question should be working fine and the page doesn't show any warning errors.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-66584~~ using repository: https://github.com/danghieu1407/moodle.git

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-66584-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-66584-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-66584-master | CI Job]

_{More information about this report}

Built on: Tue Mar 25 10:19:04 UTC 2025
Show
Code verified against automated checks. Checked MDL-66584 using repository: https://github.com/danghieu1407/moodle.git MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-66584-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-66584-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-66584-master | CI Job ] More information about this report Built on: Tue Mar 25 10:19:04 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-66584~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18754/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64241/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64242/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64243/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-66584~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18755/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64244/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64245/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64246/ Behat (Firefox - classic / complete)

Launching automatic jobs for branch ~~MDL-66584~~-master

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18756/ PHPUnit (sqlsrv / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64247/ Behat (NonJS - boost and classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64248/ Behat (Firefox - boost / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64249/ Behat (Firefox - classic / complete)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64250/ App tests (stable app version) / complete)

Built on: Sun Mar 23 21:03:16 UTC 2025
Show
Launching automatic jobs for branch MDL-66584 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18754/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64241/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64242/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64243/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-66584 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18755/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64244/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64245/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64246/ Behat (Firefox - classic / complete) Launching automatic jobs for branch MDL-66584 -master https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18756/ PHPUnit (sqlsrv / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64247/ Behat (NonJS - boost and classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64248/ Behat (Firefox - boost / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64249/ Behat (Firefox - classic / complete) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64250/ App tests (stable app version) / complete) Built on: Sun Mar 23 21:03:16 UTC 2025

To reproduce:

On a site with developer debugging turned on ...
Import the attached Moodle XML file to the question bank in a course.
Preview the newly imported question (called "Periodic table").

Note the error at the top:

Too much data passed as arguments to js_call_amd("qtype_ddimageortext/question", "init"). Generally there are better ways to pass lots of data from PHP to JavaScript, for example via Ajax, data attributes, ... . This warning is triggered if the argument string becomes longer than 1024 characters.

The message is right. In this case, we should probably switch to using data attributes.

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

big dd question.xml
25/Jun/20 8:31 PM
11 kB
Tim Hunt
image-2024-08-22-17-15-24-782.png
22/Aug/24 6:15 PM
63 kB
Hieu Vu
questions-T100-Q15 DDM Places in MK-20240815-1436.xml
25/Mar/25 5:59 PM
324 kB
Hieu Nguyen Dang
MDL-66584.png
16/Apr/25 3:10 PM
950 kB
Ron Carl Alfon Yu

caused a regression

MDL-85248 Revert changes made by MDL-66584 in stables as they are breaking old versions of the app

Closed

MOBILE-4648 Drag-drop onto image question should use blog data from HTML not AMD params

Tested

will be (partly) resolved by

MDL-58645 Make drag-and-drop onto image questions responsive and fix the print layout

Closed

Assignee:: Hieu Nguyen Dang

Reporter:: Tim Hunt

Peer reviewer:: Anupama Sarjoshi

Integrator:: Tim Hunt

Tester:: Ron Carl Alfon Yu

Participants:: Anna Carissa Sadia, Anupama Sarjoshi, CiBoT, Dani Palou, Hieu Nguyen Dang, Hieu Vu, Juan Leyva, Jun Pataleta, Ron Carl Alfon Yu, Sara Arjona (@sarjona), Simey Lameze, Tim Hunt

Votes:: 1 Vote for this issue

Watchers:: 11 Start watching this issue

Created:: 03/Sep/19 6:30 PM

Updated:: 22/Apr/25 10:33 PM

Resolved:: 17/Apr/25 8:57 PM

Estimated:

Remaining:

Logged:

1h 27m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify