-
Bug
-
Resolution: Fixed
-
Minor
-
3.7.1
-
MOODLE_37_STABLE
-
MOODLE_36_STABLE, MOODLE_37_STABLE
-
MDL-66163-master -
One of our plugins add files into files table during installation (similar to what assignment pdf feedback does). This broke mod_forum unittests on mssql/oracle (since these two databases don't use random ids).
The failures are in the line:
mod_forum_privacy_provider_testcase::test_delete_data_for_user
|
Failed asserting that actual size 2 matches expected size 0.
|
|
|
/var/www/html/mod/forum/tests/privacy_provider_test.php:1473
|
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
|
|
|
|
|
mod_forum_privacy_provider_testcase::test_delete_data_for_users
|
Failed asserting that actual size 2 matches expected size 0.
|
|
|
/var/www/html/mod/forum/tests/privacy_provider_test.php:1681
|
/var/www/html/lib/phpunit/classes/advanced_testcase.php:80
|
The code at these lines read something like this:
$this->assertCount(0, $DB->get_records_select('files', "itemid {$postinsql}", $postinparams));
|
Clearly component/filearea condition is missing
