Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66160

Badge award criteria not considering ALL required badges

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.6.5, 3.7.1, 3.8
    • Badges
    • MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE

      Was reviewing MDL-66032 and, looking in context... when it's checked that ALL the badges have been required (BADGE_CRITERIA_AGGREGATION_ALL)... there is something looking really wrong, because the $where variable is overwritten on each looping execution.

      I've not tested it, but it seems obvious that:

      1) it leads to incomplete SQL command (only last badge is checked effectively).
      2) it's not covered with tests.

      So this issue is about to achieve 1) and 2) above. Ciao

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.