-
Improvement
-
Resolution: Fixed
-
Major
-
3.5.7, 3.6.5, 3.7.1, 3.8
-
PECL solr extension v2.5.0 or compiled from source (available in https://github.com/php/pecl-search_engine-solr)
-
Any
-
MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
-
MOODLE_36_STABLE, MOODLE_37_STABLE
-
m38_
MDL-66140_Mitigate_PECL_Solr_issue_Ref_72740 -
Long story short, SolrDisMaxQuery::addQueryField() doesn't work as expected when not passing the optional boost value, since long time.
PECL solr extension has been finally GAed w/ support for PHP 7.2 and 7.3 via v2.5.0, unfortunately still including the regression above.
Test:
# export MOODLE_DOCKER_WWWROOT=/path/to/moodle-master
|
# export MOODLE_DOCKER_DB=mysql
|
# export MOODLE_DOCKER_PHP_VERSION=7.2
|
# export MOODLE_DOCKER_PHPUNIT_EXTERNAL_SERVICES=true
|
# bin/moodle-docker-compose up -d && bin/moodle-docker-wait-for-db
|
# bin/moodle-docker-compose exec webserver php admin/tool/phpunit/cli/init.php
|
# bin/moodle-docker-compose exec webserver php --ri solr
|
|
|
solr
|
|
|
Solr Support => enabled
|
Version => 2.4.0
|
Last Build Date => May 27 2019
|
Last Build Time => 00:58:51
|
# bin/moodle-docker-compose exec webserver php vendor/bin/phpunit --filter test_search search_solr_engine_testcase search/engine/solr/tests/engine_test.php -v
|
[cut]
|
OK (2 tests, 28 assertions)
|
# bin/moodle-docker-compose exec webserver apt-get update
|
# bin/moodle-docker-compose exec webserver apt-get install -y --no-install-recommends libcurl4-openssl-dev libxml2-dev
|
# bin/moodle-docker-compose exec webserver pecl install solr
|
# bin/moodle-docker-compose exec webserver php --ri solr
|
|
|
solr
|
|
|
Solr Support => enabled
|
Version => 2.5.0
|
Last Build Date => Jul 12 2019
|
Last Build Time => 20:14:06
|
# bin/moodle-docker-compose exec webserver php vendor/bin/phpunit --filter test_search search_solr_engine_testcase search/engine/solr/tests/engine_test.php -v
|
[cut]
|
FAILURES!
|
Tests: 2, Assertions: 2, Failures: 2.
|
Refs:
