Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-66039

Duplicate #page selector attribute with same value

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.6.6, 3.7.2
    • 3.6.4, 3.7, 3.8
    • Themes
    • MOODLE_36_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • MOODLE_36_STABLE, MOODLE_37_STABLE
    • MDL-66039-master
    • Hide
      1. Login as any user
      2. Open browser dev tools
      3. Find the div with id "page" (<div id="page" class=.....)
      4. Look through the list of styles and find #page
        1. Verify there is a 50px margin-top applied

      Show
      Login as any user Open browser dev tools Find the div with id "page" ( <div id="page" class=..... ) Look through the list of styles and find #page Verify there is a 50px margin-top applied

      With reference to /theme/boost/scss/moodle/drawer.scss there is the selector:

      #page {
          margin-top: $navbar-height;
      }

      which is then defined further down as:

      #page {
          margin-top: $fixed-header-y;
      }

      which overrides it.  However both $navbar-height and $fixed-header-y are the same value because of:

      $fixed-header-y: $navbar-height;

      at the top of the file.

       

       

        1. 66039-testing.png
          1.67 MB
          Andrew Lyons
        2. image-2019-08-07-16-13-27-032.png
          152 kB
          Janelle Barcega

            basbrands Bas Brands
            gb2048 Gareth J Barnard
            Glyn (Mathew) May Glyn (Mathew) May
            Andrew Lyons Andrew Lyons
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 50 minutes
                50m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.