-
Improvement
-
Resolution: Fixed
-
Minor
-
3.7
-
MOODLE_37_STABLE
-
MOODLE_38_STABLE
-
MDL-65344_master -
- Unit tests.
This method was created without having a need for it. It's only called by get_conversation_between_users() in the singular form, and in some unit tests and is not easy to read / maintain.
Considering the above two methods, what we want is as follows:
- Remove get_individual_conversations_between_users() [deprecate sadly, as it's public]
- Rewrite get_conversation_between_users() to just make a DB call based on the type and conversation hash.
- Adjust unit tests to use the rewritten method.