-
Bug
-
Resolution: Fixed
-
Minor
-
3.6.3, 3.7
-
MOODLE_36_STABLE, MOODLE_37_STABLE
-
MOODLE_36_STABLE
-
MDL-65247-master -
Hi, this is a followup/regression of MDL-64331
We are getting this scenario failing under clean:
And also with classic (master):
--profile seleniumchrome --suite clean --name 'The popup closes when clicked on dead space - Modal'
|
|
001 Scenario: The popup closes when clicked on dead space - Modal # /Users/stronk7/git_moodle/moodle/lib/tests/behat/action_modal.feature:27
|
And I click on "Calendar" "link" # /Users/stronk7/git_moodle/moodle/lib/tests/behat/action_modal.feature:30
|
The "(//html/.//a
|
[./@href][((./@id = 'Calendar' or contains(normalize-space(string(.)), 'Calendar') or contains(./@title, 'Calendar') or contains(./@rel, 'Calendar')) or .//*[(contains(concat(' ', @class, ' '), ' icon ') or name() = 'img') and (contains(./@alt, 'Calendar') or contains(./@title, 'Calendar'))])] | //html/.//*
|
[translate(./@role, 'ABCDEFGHIJKLMNOPQRSTUVWXYZ', 'abcdefghijklmnopqrstuvwxyz') = 'link'][((./@id = 'Calendar' or contains(./@value, 'Calendar')) or contains(./@title, 'Calendar') or contains(normalize-space(string(.)), 'Calendar'))])[1]" xpath node is not visible and it should be visible (Behat\Mink\Exception\ExpectationException)
|
|
1 escenario (1 fallaron)
|
7 pasos (2 pasaron, 1 fallaron, 4 saltadas)
|
0m26.77s (49.14Mb)
|
And a bisecting section points to MDL-64331 as the cause:
3f9247df888a2c791217adedc835bfa5a14524ac is the first bad commit
|
commit 3f9247df888a2c791217adedc835bfa5a14524ac
|
Author: Damyon Wiese <damyon@moodle.com>
|
Date: Thu Mar 28 09:14:10 2019 +0800
|
|
MDL-64331 modals: Be careful closing modals
|
|
Don't close a modal when the user clicks outside of it and the modal contains a form.
|
|
:040000 040000 0cdfad98f870de559d20b39245ba3ddb65b0f1f1 7531324d21a01ba4776d6154a309270e4ebbcb9a M lib
|
stronk7@~/git_moodle/moodle ((3f9247df888...) $%|BISECTING)$ 3ag The popup closes when clicked on dead space^C
|
stronk7@~/git_moodle/moodle ((3f9247df888...) $%|BISECTING)$ ag 'The popup closes when clicked on dead space'
|
For your consideration if this is just a matter of fixing the tests or does require any other change.
Finally note that, surely, master is exposed to the same problem. Just we aren't running clean tests because of its immediate removal.
Ciao
- is a regression caused by
-
MDL-64331 Changes in modal form are lost when user accidentally clicks outside of a modal
-
- Closed
-