Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64485

Allow setting of font family for append comments

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Duplicate
    • Icon: Major Major
    • None
    • 3.4.6, 3.7, 3.8.2
    • Assignment
    • MySQL
    • MOODLE_34_STABLE, MOODLE_37_STABLE, MOODLE_38_STABLE
    • Hide

      Potential Solution

      One solution that I could suggest is to make use of the following method:

      {{
      $this->SetFont($this->get_export_font_name(), '', 16.0 * $this->scale, '', true);}}

      for append_comments method defined here : https://github.com/moodle/moodle/blob/master/mod/assign/feedback/editpdf/classes/pdf.php#L254

      This ensures that the $CFG->pdfexportfont is also used for adding comments in a different language. 

      Show
      Potential Solution One solution that I could suggest is to make use of the following method: {{ $this->SetFont($this->get_export_font_name(), '', 16.0 * $this->scale, '', true);}} for append_comments method defined here : https://github.com/moodle/moodle/blob/master/mod/assign/feedback/editpdf/classes/pdf.php#L254 This ensures that the $CFG->pdfexportfont is also used for adding comments in a different language. 
    • Hide
      • As a Teacher ,create an Assignment with File Submissions enabled
      • As a student, submit a file for assignment submission. 
      • As a Teacher, to go "View All Submissions" and click " Grade" against the students submission.
      • As a Teacher, annotate the submission and add chinese character comments using the comments button that gives you yellow post it notes on the submission ( not the Feedback Comments text area box!) . Add 為特區制訂 for example.
      • Save Changes. You should see "The changes to the grade and feedback were saved"
      • As a Teacher, "View All Submissions" and click on the PDF file generated under the "Annotate PDF" column. 
      • Scroll to the last page of the Annotated PDF and you will see that all chinese characters have been replaced with ??? 
      Show
      As a Teacher ,create an Assignment with File Submissions enabled As a student, submit a file for assignment submission.  As a Teacher, to go "View All Submissions" and click " Grade" against the students submission. As a Teacher, annotate the submission and add chinese character comments using the comments button that gives you yellow post it notes on the submission ( not the Feedback Comments text area box!) . Add 為特區制訂 for example. Save Changes. You should see "The changes to the grade and feedback were saved" As a Teacher, "View All Submissions" and click on the PDF file generated under the "Annotate PDF" column.  Scroll to the last page of the Annotated PDF and you will see that all chinese characters have been replaced with  ???  

      If comments are added using the EditPDF comments widget in a language other than English, the resulting Feedback PDF downloaded replaces it with ??? as it cannot recognise the language. 

       

            Unassigned Unassigned
            hitteshahuja Hittesh Ahuja
            Votes:
            17 Vote for this issue
            Watchers:
            11 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - Not Specified
                Not Specified
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 15 minutes
                15m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.