Loading...

XML

Word

Printable

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_37_STABLE
Pull from Repository:
https://github.com/marinaglancy/moodle
Pull Main Branch:
~~MDL-64324~~-master
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...marinaglancy:MDL-64324-master
Testing Instructions:
Hide

Open any page with a form, like the one editing a forum activity, and inspect the HTML on the form

Make sure "id" attribute on the form has random suffix, for example <form autocomplete="off" action="modedit.php" method="post" accept-charset="utf-8" id="mform1_mhoRiZnTCgAddbg" class="mform">

Additionally, CiBoT should run all behat tests.
Show
Open any page with a form, like the one editing a forum activity, and inspect the HTML on the form Make sure "id" attribute on the form has random suffix, for example <form autocomplete="off" action="modedit.php" method="post" accept-charset="utf-8" id=" mform1_mhoRiZnTCgAddbg " class="mform"> Additionally, CiBoT should run all behat tests.

MoodleQuickForm constructor assigns "id" attribute to the forms with the following logic:

        static $formcounter = 1;

        if (is_null($this->getAttribute('id'))) {

            $attributes['id'] = 'mform' . $formcounter;

        $formcounter++;

As a result all forms loaded in AJAX using Fragment API have the same id="mform1"

This causes JS conflicts on the page

has a non-specific relationship to

MDL-64687 Remove mform1 references

has been marked as being related by

MDL-64554 Add module for displaying moodleform in a modal window

MDL-65217 Conflict of element ids (html attribute "id") when there are several forms on one page

Participants:: Anna Carissa Sadia, CiBoT, Eloy Lafuente (stronk7), Marina Glancy, Mihail Geshoski, Sara Arjona (@sarjona), Tim Hunt

Estimated:

Remaining:

Logged:

10m