Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64267

Double scrollbars in a conversation on Clean theme

XMLWordPrintable

    • MOODLE_36_STABLE
    • MOODLE_36_STABLE
    • MDL-64267-master
    • Hide

      Please test on both all themes(clean and boost for 3.6, classic and boost for master)

      If you are using macos for testing make sure your setup is configured to show scrollbars. (In macos: System preferences -> general > Show scrollbars : Always)

      Setup your test environment.

      1. Log in as Admin
      2. Create users s1, s2
      3. Create course C1
      4. Enrol users s1 and s2 in course C1

      Test scrolling behaviour

      1. Login as user s1
      2. Open the message drawer and search for user s2
      3. Click on the s2 username
      4. Click the top right menu and choose add as contact
      5. Send user s2 about 20 messages
      6. Verify you only see one scrollbar within the message drawer. Note there may be a second scrollbar for the full page itself.
      7. Verify you see the "Contact request sent" message positioned sticky at the top of the message container
      Show
      Please test on both all themes(clean and boost for 3.6, classic and boost for master) If you are using macos for testing make sure your setup is configured to show scrollbars. (In macos: System preferences -> general > Show scrollbars : Always) Setup your test environment. Log in as Admin Create users s1, s2 Create course C1 Enrol users s1 and s2 in course C1 Test scrolling behaviour Login as user s1 Open the message drawer and search for user s2 Click on the s2 username Click the top right menu and choose add as contact Send user s2 about 20 messages Verify you only see one scrollbar within the message drawer. Note there may be a second scrollbar for the full page itself. Verify you see the "Contact request sent" message positioned sticky at the top of the message container

      Again from Bas:

      On theme Clean there is an extra scrollbar on the div with class .content-message-container. It seems to be related to the added pb-2, I am not sure if that needs a new tracker issue.

        1. double scrollbar.png
          79 kB
          Jun Pataleta
        2. double scrollbar boost.png
          33 kB
          Bas Brands
        3. patch-MDL_64267.diff
          1 kB
          Tobias Reischmann
        4. scroll_previous_behaviour.png
          31 kB
          Sara Arjona (@sarjona)
        5. scroll_new_behaviour1.png
          28 kB
          Sara Arjona (@sarjona)
        6. scroll_new_behaviour2.png
          29 kB
          Sara Arjona (@sarjona)
        7. position-sticky.png
          118 kB
          Bas Brands
        8. integration36.jpg
          15 kB
          Anna Carissa Sadia
        9. integration36.mp4
          687 kB
          Anna Carissa Sadia
        10. stable_36.jpg
          19 kB
          Anna Carissa Sadia
        11. stable_master.jpg
          7 kB
          Anna Carissa Sadia
        12. MDL-64267.jpg
          17 kB
          Anna Carissa Sadia
        13. MDL-64267_integration36.jpg
          18 kB
          Anna Carissa Sadia

            tobias.reischmann Tobias Reischmann
            jpataleta Jun Pataleta
            Sara Arjona (@sarjona) Sara Arjona (@sarjona)
            Jake Dallimore Jake Dallimore
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            6 Vote for this issue
            Watchers:
            10 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 6 hours, 16 minutes
                6h 16m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.