Loading...

XML

Word

Printable

Affected Branches:
MOODLE_36_STABLE
Fixed Branches:
MOODLE_36_STABLE
Pull from Repository:
git://github.com/mickhawkins/moodle.git
Pull Main Branch:
~~MDL-64091~~-master
Pull Main Diff URL:
https://github.com/mickhawkins/moodle/compare/01acb1ea90...MDL-64091-master
Testing Instructions:
Hide

Set up

Log in as admin.

Have a Moodle site with the theme set to clean.

Clear all site/theme caches.

Have a student enrolled in a course, with multiple activities due (eg chat and assignment).

Test

Log in as the student.

Visit the dashboard, find the Timeline block.

CONFIRM You can see the relevant icons next to each of the timeline items (eg chat/speech bubble icon next to chat, assignment/paper in hand icon next to the assignment).

CONFIRM the additional black icons shown in Przemek's example in this issue are not visible.
Show
Set up Log in as admin. Have a Moodle site with the theme set to clean. Clear all site/theme caches. Have a student enrolled in a course, with multiple activities due (eg chat and assignment). Test Log in as the student. Visit the dashboard, find the Timeline block. CONFIRM You can see the relevant icons next to each of the timeline items (eg chat/speech bubble icon next to chat, assignment/paper in hand icon next to the assignment). CONFIRM the additional black icons shown in Przemek's example in this issue are not visible.

Make sure Timeline has activities to show to the user.
Switch theme to Clean (clear theme caches and purge other caches)
Visit Dashboard's Timeline.
Each activity icon will be additionally "accompanied" by an ugly quartet of four black icons as if loaded underneath the main icons - a champagne glass icon, a musical note, a triangular arrow and a square.
The bug affects Timeline's both sort orders - by courses and by dates.

This looks rather ugly and I think it should be fixed for 36 release for the Clean theme to be usable with the Timeline block at all.

Tested in Firefox, Chrome, MS Edge under Windows 10. Tried both qa.moodle.net and a local install, although both on the same machine.

caused a regression

MDL-64217 Connecting spinner icon showing in Clean on the Add to Contacts button

is duplicated by

MDL-64193 Weird icon displayed while searching using the clean theme

Participants:: CiBoT, Janelle Barcega, Jun Pataleta, Michael Hawkins, Przemek Kaszubski, Ryan Wyllie

Estimated:

Remaining:

Logged:

10m