Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-64008

Optional badge fields should not be displayed on the badge page when empty

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.6
    • 3.6
    • Badges
    • MOODLE_36_STABLE
    • MOODLE_36_STABLE
    • MDL-64008-master
    • Hide
      1. Log in as a teacher and go to a course.
      2. Click 'Add a new badge' (either via the gear menu or the Administration block, depending upon the theme)
      3. Complete the form but only fill out the required fields, then click the button 'Create badge'.
      4. Add a 'Manual issue by role' criterion and select Teacher as the role.
      5. Enable access to the badge.
      6. Assign the badge to a student.
      7. Under the Recipients tab click the "View issued badge" link next to a user.
      8. Check that there are no fields that display nothing.
      9. Create a new badge (following the steps above).
      10. This time add a few of the non required fields.
      11. Assign a badge to a student and view their badge.
      12. Check that the fields that were filled out are displayed.
      Show
      Log in as a teacher and go to a course. Click 'Add a new badge' (either via the gear menu or the Administration block, depending upon the theme) Complete the form but only fill out the required fields, then click the button 'Create badge'. Add a 'Manual issue by role' criterion and select Teacher as the role. Enable access to the badge. Assign the badge to a student. Under the Recipients tab click the "View issued badge" link next to a user. Check that there are no fields that display nothing. Create a new badge (following the steps above). This time add a few of the non required fields. Assign a badge to a student and view their badge. Check that the fields that were filled out are displayed.

      As found when testing MDLQA-12705, the optional badge fields - version, image author's name, email, URL and image caption - are displayed on the badge page when empty. This doesn't look good, as illustrated in the attached screenshot. Also, maybe the language can be omitted too?

      Steps to reproduce:

      1. Create a new badge, filling in only the required fields.
      2. Assign it to a user.
      3. Go to the user's profile page and click on the badge.

      Expected result: Optional badge fields are not displayed on the badge page when empty.

       

       

        1. badge details with empty badge fields.png
          32 kB
          Helen Foster
        2. MDL-64008.PNG
          60 kB
          Anna Carissa Sadia

            abgreeve Adrian Greeve
            tsala Helen Foster
            Jake Dallimore Jake Dallimore
            Eloy Lafuente (stronk7) Eloy Lafuente (stronk7)
            Anna Carissa Sadia Anna Carissa Sadia
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 10 minutes
                10m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.