Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-63025

Test failure with sassc

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Deferred
    • Icon: Minor Minor
    • None
    • 3.5.1, 3.6
    • Themes, Unit tests
    • None

      docker exec -t runc436df57e7ff4819 php vendor/bin/phpunit --disallow-test-output --fail-on-risky --log-junit /shared/log.junit lib/tests/scss_test.php --verbose
      Moodle 3.6dev (Build: 20180727), 6e8235c7d3957120f16f5b9d4df8ef1ec82558b5
      Php: 7.1.20, pgsql: 9.6.7, OS: Linux 4.9.93-linuxkit-aufs x86_64
      PHPUnit 6.5.8 by Sebastian Bergmann and contributors.
       
      Runtime:       PHP 7.1.20
      Configuration: /var/www/html/phpunit.xml
       
      .......F                                                            8 / 8 (100%)
       
      Time: 527 ms, Memory: 38.00MB
       
      There was 1 failure:
       
      1) core_scss_testcase::test_scss_compilation_with_sassc with data set "nested" ('nav {\n                      ...     }', 'nav ul {\n  margin: 0;\n  pad...e; }\n')
      Failed asserting that two strings are identical.
      --- Expected
      +++ Actual
      @@ @@
       'nav ul {
         margin: 0;
         padding: 0;
         list-style: none; }
      -  nav li {
      -    display: inline-block; }
      -  nav a {
      -    display: block;
      -    padding: 6px 12px;
      -    text-decoration: none; }
      +
      +nav li {
      +  display: inline-block; }
      +
      +nav a {
      +  display: block;
      +  padding: 6px 12px;
      +  text-decoration: none; }
       
      /var/www/html/lib/tests/scss_test.php:152
      /var/www/html/lib/phpunit/classes/advanced_testcase.php:80
       
      To re-run:
       vendor/bin/phpunit --verbose "core_scss_testcase" lib/tests/scss_test.php
       
      FAILURES!
      Tests: 8, Assertions: 8, Failures: 1.
      

      Looks to be purely whitespace. I also note that the expected vs. actual tests are reversed.

            dobedobedoh Andrew Lyons
            dobedobedoh Andrew Lyons
            Votes:
            1 Vote for this issue
            Watchers:
            8 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.