-
Bug
-
Resolution: Fixed
-
Minor
-
3.4.5, 3.5.1, 3.6
-
MOODLE_34_STABLE, MOODLE_35_STABLE, MOODLE_36_STABLE
-
MOODLE_34_STABLE, MOODLE_35_STABLE
-
MDL-62891-master-callable_name -
We are seeing the following error on a community site after having it upgraded to 3.5.1:
Warning: var_export does not handle circular references in /opt/app/lib/classes/shutdown_manager.php on line 83
|
As can be seen in the code, this is caused by
error_log('Exception ignored in shutdown function '.var_export($callback, true).':'.$e->getMessage());
|
The callback can contain circular references. In our case, this is caused by tool_log\log\manager that registers its own static method dispose() as a callback.
We should think of a safer / better way to extract the class name and method name in these cases so that we have something like this in error logs:
Exception ignored in shutdown function tool_log\log\manager::dispose()
|
and not the rubbish as found e.g. in https://tracker.moodle.org/browse/MDL-46904?focusedCommentId=314863&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-314863
- Discovered while testing
-
MDLSITE-5489 Upgrade moodle.net to 3.5.1
-
- Resolved
-