Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-62034

User Tours: Reset-Link appears on assignment grading page

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • 3.6.6, 3.7.2
    • 3.5, 3.6.5, 3.7.1
    • User Tours
    • MOODLE_35_STABLE, MOODLE_36_STABLE, MOODLE_37_STABLE
    • MOODLE_36_STABLE, MOODLE_37_STABLE
    • MDL-62034-master
    • Hide
      1. Login as Admin
      2. Go to the user tours page (/admin/tool/usertours/configure.php)
      3. Import the attached user tour
      4. Login as a teacher and open a course
      5. Turn editing on
      6. Create a new Assignment with a title and default values
      7. Save and display
      8. Click the button "Grade"
      9. End the tour that appears
        1. Confirm that there is a link to reset the user tour on this page in the bottom left as pictured
      Show
      Login as Admin Go to the user tours page (/admin/tool/usertours/configure.php) Import the attached user tour Login as a teacher and open a course Turn editing on Create a new Assignment with a title and default values Save and display Click the button "Grade" End the tour that appears Confirm that there is a link to reset the user tour on this page in the bottom left as pictured

      Hi,
      we've created a user tour for our users that should pop up on activity pages:
      /mod/%/view.php

      The grading page is not called with an own URL, but it is used with the assignment url and the grading parameter (mod/assign/view.php?id=12345&action=grader).

      This is why the tour is matching the URL and the link to reset is integrated on the page. The problem is that on this page, there's no footer and in our case the code is being intserted between several <javascript> tags and it also contains an empty link:

      <div class="usertour">
          <a href="#" data-action="tool_usertours/resetpagetour">Reset user tour</a>
      </div>
      

      The result looks like this:

      Steps to reproduce:

      • Login as Admin
      • Go to the user tours page (/admin/tool/usertours/configure.php)
      • Import the attached user tour
      • Login as a teacher and open a course
      • Turn editing on
      • Create a new Assignment with a title and default values
      • Save and display
      • Click the button "Grade"
      • See the result: A link to reset the user tour is displayed in the top left corner and overlaps the navigation links. Furthermore the reset user tour link is not clickable (due to href=#).

      Best, Kathrin

            dobedobedoh Andrew Lyons
            kosswa Kathrin Osswald
            Andrew Lyons Andrew Lyons
            Jun Pataleta Jun Pataleta
            Janelle Barcega Janelle Barcega
            Votes:
            0 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved:

                Estimated:
                Original Estimate - 0 minutes
                0m
                Remaining:
                Remaining Estimate - 0 minutes
                0m
                Logged:
                Time Spent - 45 minutes
                45m

                  Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.