Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 4.4.8, 4.5.4
Affects Version/s: 3.3.3, 3.4.2, 4.4.7, 4.5.3
Component/s: Gradebook
Labels:
- ci
- release_notes
- triaged

Affected Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_404_STABLE, MOODLE_405_STABLE
Fixed Branches:
MOODLE_404_STABLE, MOODLE_405_STABLE
Pull from Repository:
https://github.com/paulholden/moodle/
Pull 4.4 Branch:
~~MDL-61730~~-404
Pull 4.4 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_404_STABLE...paulholden:MDL-61730-404
Pull 4.5 Branch:
~~MDL-61730~~-405
Pull 4.5 Diff URL:
https://github.com/moodle/moodle/compare/MOODLE_405_STABLE...paulholden:MDL-61730-405
Pull Main Branch:
~~MDL-61730~~
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/main...paulholden:MDL-61730
Testing Instructions:
Hide

Log in as admin

Navigate to Grades > General settings in site administration

Tick Enable publishing and save changes

Create a course

Navigate to course Grades

From navigation select Import

Select Import as XML file

Confirm you don't see the following message:

Did you remember to call setType() for 'iprestriction'? Defaulting to PARAM_RAW cleaning.
Show
Log in as admin Navigate to Grades > General settings in site administration Tick Enable publishing and save changes Create a course Navigate to course Grades From navigation select Import Select Import as XML file Confirm you don't see the following message: Did you remember to call setType() for 'iprestriction'? Defaulting to PARAM_RAW cleaning.
Pre-check results:
Hide

Code verified against automated checks.

Checked ~~MDL-61730~~ using repository: https://github.com/paulholden/moodle/

MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-61730-404 | CI Job]

MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-61730-405 | CI Job]

main (0 errors / 0 warnings) [branch: MDL-61730 | CI Job]

_{More information about this report}

Built on: Wed Apr 2 12:52:49 UTC 2025
Show
Code verified against automated checks. Checked MDL-61730 using repository: https://github.com/paulholden/moodle/ MOODLE_404_STABLE (0 errors / 0 warnings) [branch: MDL-61730-404 | CI Job ] MOODLE_405_STABLE (0 errors / 0 warnings) [branch: MDL-61730-405 | CI Job ] main (0 errors / 0 warnings) [branch: MDL-61730 | CI Job ] More information about this report Built on: Wed Apr 2 12:52:49 UTC 2025
Automated test results:
Hide

Launching automatic jobs for branch ~~MDL-61730~~-404

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18888/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64670/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64671/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-61730~~-405

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18889/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64672/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64673/ Behat (Firefox - boost)

Launching automatic jobs for branch ~~MDL-61730~~

https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18890/ PHPUnit (sqlsrv)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64674/ Behat (NonJS - boost and classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64675/ Behat (Firefox - boost)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64676/ Behat (Firefox - classic)

https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64677/ App tests (stable app version)

Built on: Wed Apr 2 10:30:55 UTC 2025
Show
Launching automatic jobs for branch MDL-61730 -404 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18888/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64670/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64671/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-61730 -405 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18889/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64672/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64673/ Behat (Firefox - boost) Launching automatic jobs for branch MDL-61730 https://ci.moodle.org/view/Testing/job/DEV.02%20-%20Developer-requested%20PHPUnit/18890/ PHPUnit (sqlsrv) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64674/ Behat (NonJS - boost and classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64675/ Behat (Firefox - boost) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64676/ Behat (Firefox - classic) https://ci.moodle.org/view/Testing/job/DEV.01%20-%20Developer-requested%20Behat/64677/ App tests (stable app version) Built on: Wed Apr 2 10:30:55 UTC 2025

Steps to Replicate

Log in as Admin
Enable gradepublishing
Go to a course
Go to gradebook
Select the "Import" tab
Select the XML tab
the following message appears:

Did you remember to call setType() for 'iprestriction'? Defaulting to PARAM_RAW cleaning.
line 1340 of /lib/formslib.php: call to debugging()
line 312 of /lib/formslib.php: call to moodleform->detectMissingSetType()
line 218 of /lib/formslib.php: call to moodleform->_process_submission()
line 44 of /grade/import/xml/index.php: call to moodleform->__construct()

- - Sort By Name
  - Sort By Date
  - Ascending
  - Descending
  - Thumbnails
  - List
  - Download All

(1) 8 Passed -- (Main)MDL-61730.png
03/Apr/25 11:10 AM
108 kB
Kim Jared Lucas
61730 peer review - manual test.png
02/Apr/25 5:49 PM
55 kB
Andrew Gosali
61730 replicate - without whoops.png
02/Apr/25 1:58 PM
51 kB
Andrew Gosali
61730 replicate - with whoops.png
02/Apr/25 1:58 PM
153 kB
Andrew Gosali
image-2018-04-17-11-14-09-989.png
17/Apr/18 7:14 PM
14 kB
Janelle Barcega

has been marked as being related by

MDL-40469 Fix missing setType calls when exporting gradebook

Closed

Assignee:: Paul Holden

Reporter:: Juan Felipe Martinez

Peer reviewer:: Andrew Gosali

Integrator:: Shamim Rezaie

Tester:: Kim Jared Lucas

Participants:: Andrew Gosali, CiBoT, Janelle Barcega, Juan Felipe Martinez , Kim Jared Lucas, Paul Holden, Shamim Rezaie

Votes:: 0 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 23/Mar/18 12:09 PM

Updated:: 10/Apr/25 10:48 AM

Resolved:: 04/Apr/25 11:43 PM

Estimated:

Remaining:

Logged:

1h 46m

Details

Description

Attachments

Attachments

Issue Links

Activity

People

Dates

Time Tracking

Clockify