-
Bug
-
Resolution: Fixed
-
Minor
-
3.3.4, 3.4, 3.5
-
MOODLE_33_STABLE, MOODLE_34_STABLE, MOODLE_35_STABLE
-
MOODLE_33_STABLE, MOODLE_34_STABLE
-
MDL-61576-master -
- No testing instructions required. Sanity check the diff. No additional code is being executed, we just removed an if statement that was always returning true.
The variable $typeconfig is never passed, but is used in the function. The only reason it doesn't break is because we use !isset($typeconfig['allowinstructorcustom']) and isset() won't complain. This was discovered reviewing MDL-60416 which will address this issue in 3.5 (assuming it gets integrated), but this still needs fixing in prior supported branches.