Loading...

XML

Word

Printable

Type: Bug
Resolution: Fixed
Priority: Minor
Fix Version/s: 3.3.5, 3.4.2
Affects Version/s: 3.1.10, 3.2.7, 3.3.3, 3.4.1
Component/s: LTI provider
Labels:
- CatalystIT
- ci
- partner
- triaged

Affected Branches:
MOODLE_31_STABLE, MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
Fixed Branches:
MOODLE_33_STABLE, MOODLE_34_STABLE
Pull from Repository:
https://github.com/peikk0/moodle.git
Pull Main Branch:
mod-lti-fix-test-with-hardcoded-url
Pull Main Diff URL:
https://github.com/moodle/moodle/compare/master...peikk0:mod-lti-fix-test-with-hardcoded-url
Testing Instructions:
1. Sanity check - CiBot can do the rest.

The hardcoded URL from tests/fixtures/ims_cartridge_basic_lti_link.xml
doesn't match the expected value in the unit tests if TEST_EXTERNAL_FILES_HTTPS_URL is defined.

The attached patch fixes the test by using the same hardcoded URL instead of the generated one. It applies cleanly on all supported versions.

Assignee:: Unassigned

Reporter:: Pierre Guinoiseau

Peer reviewer:: Mark Nelson

Integrator:: David Monllaó

Tester:: CiBoT

Participants:: CiBoT, David Monllaó, Eloy Lafuente (stronk7), Mark Nelson, Pierre Guinoiseau

Votes:: 0 Vote for this issue

Watchers:: 7 Start watching this issue

Created:: 07/Feb/18 8:04 PM

Updated:: 16/Feb/18 9:49 AM

Resolved:: 16/Feb/18 9:49 AM

Details

Description

Attachments

Activity

People

Dates

Clockify