Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60945

core_completion_get_activities_completion_status web service internally gets more progress records than required

XMLWordPrintable

    • MOODLE_32_STABLE, MOODLE_33_STABLE, MOODLE_34_STABLE
    • MOODLE_33_STABLE, MOODLE_34_STABLE
    • Easy
    • Hide

      The unit tests should cover this, specifically:

      vendor/bin/phpunit core_completion_externallib_testcase completion/tests/externallib_test.php

      Show
      The unit tests should cover this, specifically: vendor/bin/phpunit core_completion_externallib_testcase completion/tests/externallib_test.php

      When core_completion_external::get_activities_completion_status() is called it retrieves progress for all users on a course, before discarding all but one record.

      The query that does this can have its efficiency improved by using completion_info::get_progress_all in a way that only gets the progress for the user that the method is interested in.

            nmagill Neill Magill
            nmagill Neill Magill
            Jake Dallimore Jake Dallimore
            Damyon Wiese Damyon Wiese
            CiBoT CiBoT
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:
              Resolved:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.