Uploaded image for project: 'Moodle'
  1. Moodle
  2. MDL-60672

Review phpunit risky tests

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • None
    • 3.4
    • Unit tests
    • MOODLE_34_STABLE

      Working on MDL-60611, to get phpunit 6 support to Moodle 3.4 and up... one of the things detected is that we have a good number of "risky" (without assertions") tests in codebase.

      We have them not being reported using beStrictAboutTestsThatDoNotTestAnything="false" in phpunit.xml, but ideally we should not have tests of this type.

      1) if they are empty should be deleted.
      2) if they are not tests, but support stuff, should be renamed or moved.

      So, this is about:

      a) detect all the risky tests we have
      b) try to kill them, so we can go to the default "beStrict=true"

      Ciao

            Unassigned Unassigned
            stronk7 Eloy Lafuente (stronk7)
            Votes:
            2 Vote for this issue
            Watchers:
            4 Start watching this issue

              Created:
              Updated:

                Error rendering 'clockify-timesheets-time-tracking-reports:timer-sidebar'. Please contact your Jira administrators.