Loading...

XML

Word

Printable

Affected Branches:
MOODLE_34_STABLE
Fixed Branches:
MOODLE_34_STABLE
Epic Link:
Calendar Improvements
Pull from Repository:
git://github.com/lameze/moodle.git
Pull Main Branch:
~~MDL-60608~~-master
Pull Main Diff URL:
https://github.com/lameze/moodle/compare/d12e409...MDL-60608-master
Testing Instructions:
Hide

Login as admin

Make sure you have guest access to your site.

Add Calendar block to site home

Log off

View current month and log in as GUEST

Try to navigate month

Make sure you don't get the error mentioned below.
Show
Login as admin Make sure you have guest access to your site. Add Calendar block to site home Log off View current month and log in as GUEST Try to navigate month Make sure you don't get the error mentioned below.

The current default for defaulteventcontext is null. This leads to:

defaulteventcontext => Invalid response value detected: Invalid external api response: the value is "", the server was expecting "int" type

Error code: invalidresponse

* line 424 of /lib/externallib.php: invalid_response_exception thrown

* line 233 of /lib/externallib.php: call to external_api::clean_returnvalue()

* line 59 of /lib/ajax/service.php: call to external_api::call_external_function()

Apparently null is not a valid int.

Personally I'd say that this is a bug in the WS, and that an optional value should accept null as a default.

This is seen by:

Participants:: Andrew Lyons, CiBoT, David Monllaó, Jun Pataleta, Mihail Geshoski, Sara Arjona (@sarjona), Simey Lameze